Bug 73073 - [Chromium] Move the next traunch of headers into public/platform
Summary: [Chromium] Move the next traunch of headers into public/platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-24 01:41 PST by Adam Barth
Modified: 2011-11-27 22:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (175.38 KB, patch)
2011-11-24 01:46 PST, Adam Barth
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-11-24 01:41:01 PST
[Chromium] Move the next traunch of headers into public/platform
Comment 1 Adam Barth 2011-11-24 01:46:00 PST
Created attachment 116488 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-26 23:59:58 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2011-11-27 20:58:47 PST
Comment on attachment 116488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116488&action=review

> Source/WebKit/chromium/public/WebGraphicsContext3D.h:-129
> -    virtual bool initialize(Attributes, WebView*, bool renderDirectlyToWebView) = 0;

we're going to want to unwind this dependency on WebView at some point.

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:53
> +class WebApplicationCacheHost; // FIXME: Does this belong in platform?

the storage systems are interesting.  one approach is to say yes, but we need to ensure that policy decisions are handled at the Web{Frame,View}Client level instead.  this is what you would do if it was about access to the filesystem or network stack, so why not other subsystems like the appcache or indexed db backend?
Comment 4 Adam Barth 2011-11-27 22:58:37 PST
> we're going to want to unwind this dependency on WebView at some point.

I've added a FIXME.

> > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:53
> > +class WebApplicationCacheHost; // FIXME: Does this belong in platform?
> 
> the storage systems are interesting.  one approach is to say yes, but we need to ensure that policy decisions are handled at the Web{Frame,View}Client level instead.  this is what you would do if it was about access to the filesystem or network stack, so why not other subsystems like the appcache or indexed db backend?

Makes sense.  I'll need to study these classes more to see how close we are to make that work.
Comment 5 Adam Barth 2011-11-27 22:59:33 PST
Committed r101224: <http://trac.webkit.org/changeset/101224>