Bug 73065 - [Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
: [Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-23 18:34 PST by Adam Barth
Modified: 2011-11-23 23:03 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2011-11-23 18:34 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-11-23 18:34:09 PST
[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
Comment 1 Adam Barth 2011-11-23 18:34:43 PST
Created attachment 116465 [details]
Patch
Comment 2 Eric Seidel 2011-11-23 21:56:16 PST
Comment on attachment 116465 [details]
Patch

LGTM.  You may want fishd's approval as well.
Comment 3 WebKit Review Bot 2011-11-23 21:57:50 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Adam Barth 2011-11-23 22:09:32 PST
Comment on attachment 116465 [details]
Patch

He reviewed the original patch with the FIXME.  I'm not that worried about it.
Comment 5 Eric Seidel 2011-11-23 22:19:49 PST
Oh reviewbot, you're so smart.
Comment 6 Darin Fisher (:fishd, Google) 2011-11-23 22:57:50 PST
Yes, R+
Comment 7 WebKit Review Bot 2011-11-23 23:03:17 PST
Comment on attachment 116465 [details]
Patch

Clearing flags on attachment: 116465

Committed r101121: <http://trac.webkit.org/changeset/101121>
Comment 8 WebKit Review Bot 2011-11-23 23:03:22 PST
All reviewed patches have been landed.  Closing bug.