Bug 73041 - Web Inspector: Simple Console UI improvement: remove "All" button
Summary: Web Inspector: Simple Console UI improvement: remove "All" button
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 12:06 PST by johnjbarton
Modified: 2011-11-23 18:35 PST (History)
10 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2011-11-23 12:06:19 PST
The Web Inspector Console panel has four buttons for filtering the log:
  All | Errors Warnings Logs
Only one button is valid at a time. 

Any reasonable sized page generates thousands of spurious warnings, few if any involve things that devs can take action on. So the setting I want is "Errors and Logs but no Warnings".

A better UI would remove the All button and make the remaining buttons 'checkbox'-like. That is, when these remaining buttons are selected, the corresponding log entries are shown, else not. Then if a dev wants "All", they select all three checkbox-like buttons.

Just in case I am not clear:


Result:               Old Selection     New Selection
Errors+Logs+Warnings    All               Errors+Logs+Warnings
Errors                  Errors            Errors     
Logs                    Logs              Logs
Warnings                Warnings          Warnings
Errors+Logs             impossible        Errors+Logs
Warnings+Errors         impossible        Warnings+Errors
Logs+Warnings           impossible        Logs+Warnings
Comment 1 Pavel Feldman 2011-11-23 12:13:24 PST
These filter buttons have checkbox behavior. Use Cmd/Ctrl+click to toggle. Do you want us to render them as checkboxes?
Comment 2 johnjbarton 2011-11-23 13:24:08 PST
(In reply to comment #1)
> These filter buttons have checkbox behavior. 

At least in Chrome 17, these buttons have radio-button behavior. If you click one button, it is selected and the others are unselected.

> Use Cmd/Ctrl+click to toggle. 

I think this secret behavior ought to be the default for click and the current behavior should be wired to the secret option (secret as in no simple way to discover). Of course you probably don't want to make this change without some UI change as well so my vote would be to do this + remove All

> Do you want us to render them as checkboxes?

I think if they acted like checkboxes the rendering issues would not be as important. 

I think All is extraneous, but if you want it, then it should select All. The selection state of the console should be reflected in the state of the buttons. So if Errors are showing in the Console, the Error button should be selected. If All is a checkbox meaning "select all three other boxes" then

  All: off-> on should cause Errors,Logs,and Warnings -> On
  All: on -> off well this case makes no sense, but ok, -> Off

Note that if we don't have All, and the UI comes up with all three options selected, the user gets immediate understanding when they try a button: it goes to unselected and the console filters those logs.
Comment 3 Timothy Hatcher 2011-11-23 18:34:41 PST
You can get this today by Command clicking to select multiple items and deselect others.
Comment 4 Timothy Hatcher 2011-11-23 18:35:44 PST
(Sorry, replied before seeing Pavel say the same thing.)