Bug 73031 - Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
Summary: Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 10:55 PST by Vincent Scheib
Modified: 2011-11-23 16:25 PST (History)
2 users (show)

See Also:


Attachments
Patch (12.71 KB, patch)
2011-11-23 12:19 PST, Vincent Scheib
no flags Details | Formatted Diff | Diff
Patch for landing (12.81 KB, patch)
2011-11-23 14:34 PST, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2011-11-23 10:55:16 PST
Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent
Comment 1 Vincent Scheib 2011-11-23 12:19:31 PST
Created attachment 116395 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-11-23 14:06:34 PST
Comment on attachment 116395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116395&action=review

ok with nits:

> Source/WebCore/ChangeLog:3
> +        Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent

Usually, I try to formulate the bug title as "here's what I am doing". In this case, I would title it:

Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.

> Source/WebCore/ChangeLog:8
> +        No new tests.

This needs an explanation, like:

No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.
Comment 3 Vincent Scheib 2011-11-23 14:34:21 PST
Created attachment 116430 [details]
Patch for landing
Comment 4 Alexey Proskuryakov 2011-11-23 14:38:49 PST
Comment on attachment 116430 [details]
Patch for landing

This is breaking Mac build:

Source/WebKit/mac/WebView/WebPDFView.mm:        event = MouseEvent::create(eventNames().clickEvent, true, true, 0, [nsEvent clickCount], 0, 0, 0, 0,

When making changes like this, please grep everywhere in Sources and Tools.
Comment 5 Alexey Proskuryakov 2011-11-23 14:39:33 PST
Comment on attachment 116430 [details]
Patch for landing

I'm not making any sense.
Comment 6 WebKit Review Bot 2011-11-23 16:25:55 PST
Comment on attachment 116430 [details]
Patch for landing

Clearing flags on attachment: 116430

Committed r101111: <http://trac.webkit.org/changeset/101111>
Comment 7 WebKit Review Bot 2011-11-23 16:25:59 PST
All reviewed patches have been landed.  Closing bug.