Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent
Created attachment 116395 [details] Patch
Comment on attachment 116395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116395&action=review ok with nits: > Source/WebCore/ChangeLog:3 > + Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent Usually, I try to formulate the bug title as "here's what I am doing". In this case, I would title it: Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents. > Source/WebCore/ChangeLog:8 > + No new tests. This needs an explanation, like: No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.
Created attachment 116430 [details] Patch for landing
Comment on attachment 116430 [details] Patch for landing This is breaking Mac build: Source/WebKit/mac/WebView/WebPDFView.mm: event = MouseEvent::create(eventNames().clickEvent, true, true, 0, [nsEvent clickCount], 0, 0, 0, 0, When making changes like this, please grep everywhere in Sources and Tools.
Comment on attachment 116430 [details] Patch for landing I'm not making any sense.
Comment on attachment 116430 [details] Patch for landing Clearing flags on attachment: 116430 Committed r101111: <http://trac.webkit.org/changeset/101111>
All reviewed patches have been landed. Closing bug.