RESOLVED FIXED 73031
Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents. 
https://bugs.webkit.org/show_bug.cgi?id=73031
Summary Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
Vincent Scheib
Reported 2011-11-23 10:55:16 PST
Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent
Attachments
Patch (12.71 KB, patch)
2011-11-23 12:19 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.81 KB, patch)
2011-11-23 14:34 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2011-11-23 12:19:31 PST
Created attachment 116395 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-11-23 14:06:34 PST
Comment on attachment 116395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116395&action=review ok with nits: > Source/WebCore/ChangeLog:3 > + Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent Usually, I try to formulate the bug title as "here's what I am doing". In this case, I would title it: Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents. > Source/WebCore/ChangeLog:8 > + No new tests. This needs an explanation, like: No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.
Vincent Scheib
Comment 3 2011-11-23 14:34:21 PST
Created attachment 116430 [details] Patch for landing
Alexey Proskuryakov
Comment 4 2011-11-23 14:38:49 PST
Comment on attachment 116430 [details] Patch for landing This is breaking Mac build: Source/WebKit/mac/WebView/WebPDFView.mm: event = MouseEvent::create(eventNames().clickEvent, true, true, 0, [nsEvent clickCount], 0, 0, 0, 0, When making changes like this, please grep everywhere in Sources and Tools.
Alexey Proskuryakov
Comment 5 2011-11-23 14:39:33 PST
Comment on attachment 116430 [details] Patch for landing I'm not making any sense.
WebKit Review Bot
Comment 6 2011-11-23 16:25:55 PST
Comment on attachment 116430 [details] Patch for landing Clearing flags on attachment: 116430 Committed r101111: <http://trac.webkit.org/changeset/101111>
WebKit Review Bot
Comment 7 2011-11-23 16:25:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.