Bug 73018 - [EFL] Remove the ewk_protocol_handler-related code
Summary: [EFL] Remove the ewk_protocol_handler-related code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 06:18 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2011-12-01 17:32 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch (22.68 KB, patch)
2011-12-01 13:06 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-11-23 06:18:00 PST
This functionality has been broken since r99364, which stopped setting the "webkit-resource" property needed by ewk_protocol_handler_soup.cpp.

After giving it some thought, it looks clear that this code should not be in ewk at all: it is very backend-specific (even in the function signatures it expects), and it only allows callers to register schemes once and provide a single handler to all of them, which does not make much sense.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-12-01 13:06:21 PST
Created attachment 117468 [details]
Proposed patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-12-01 13:07:55 PST
CC'ing mrobinson; this should fix the issue discussed on IRC a few weeks ago in which r99364 removed our custom handler code in ewk.
Comment 3 WebKit Review Bot 2011-12-01 17:32:48 PST
Comment on attachment 117468 [details]
Proposed patch

Clearing flags on attachment: 117468

Committed r101726: <http://trac.webkit.org/changeset/101726>
Comment 4 WebKit Review Bot 2011-12-01 17:32:52 PST
All reviewed patches have been landed.  Closing bug.