Bug 73017 – overflow: hidden breaks ul bullet points

• Status: NEW
• Component: CSS

[Der Tung]

When adding an overflow: overflow hidden to an element that is contained in a list element the bullet point for that entry is not there.

Tested with:
Google Chrome 15.0.874.121 m
Safari 5.1.1 (7534.51.22)

[David Barr]

Created attachment 116471 [details]
Simple reproduction

Confirmed on Google Chrome 17.0.948.0 (Official Build 111327) canary on Mac OS X (WebKit 101035) and WebKit Nightly (101106).

[karl]

Chrome has a similar bug and a patch in the process
https://bugs.chromium.org/p/chromium/issues/detail?id=626293

[karl]

This was also opened as a Web Compatibility issue on 
https://webcompat.com/issues/5335

[Ahmad Saleem]

Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

in 'generatesLineBoxesForInlineChild' function:

if (child.hasNonVisibleOverflow())
           break;

___

Fixes and start showing 'bullets' but mess-up whole alignment. So there is more to do and also it leads to two more WPT failures.

[Ahmad Saleem]

WPT failures:

imported/w3c/web-platform-tests/css/css-lists/list-and-block-textarea-001.html [ Failure ]
  imported/w3c/web-platform-tests/css/css-lists/list-and-margin-collapse-001.html [ Failure ]

[Karl Dubost]

Ahmad,
Chrome fixed it in getParentOfFirstLineBox(), not generatesLineBoxesForInlineChild()


which in WebKit is
https://searchfox.org/wubkat/rev/5fb255b53fc547d77ec57e9d2d59b9cb8762d59b/Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#46-73

Is it what you tried?

[Ahmad Saleem]

(In reply to Karl Dubost from comment #6)
> Ahmad,
> Chrome fixed it in getParentOfFirstLineBox(), not
> generatesLineBoxesForInlineChild()
> 
> 
> which in WebKit is
> https://searchfox.org/wubkat/rev/5fb255b53fc547d77ec57e9d2d59b9cb8762d59b/
> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#46-73
> 
> Is it what you tried?

Yes - I think I copied the wrong function name but 'getParentOfFirstLineBox', was where I applied this patch.

[Radar WebKit Bug Importer]

<rdar://problem/122588183>