Bug 73017 - overflow: hidden breaks ul bullet points
Summary: overflow: hidden breaks ul bullet points
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: http://s15263924.onlinehome-server.in...
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2011-11-23 05:03 PST by Der Tung
Modified: 2024-02-08 15:42 PST (History)
6 users (show)

See Also:


Attachments
Simple reproduction (324 bytes, text/html)
2011-11-23 19:38 PST, David Barr
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Der Tung 2011-11-23 05:03:35 PST
When adding an overflow: overflow hidden to an element that is contained in a list element the bullet point for that entry is not there.

Tested with:
Google Chrome 15.0.874.121 m
Safari 5.1.1 (7534.51.22)
Comment 1 David Barr 2011-11-23 19:38:52 PST
Created attachment 116471 [details]
Simple reproduction

Confirmed on Google Chrome 17.0.948.0 (Official Build 111327) canary on Mac OS X (WebKit 101035) and WebKit Nightly (101106).
Comment 2 karl 2017-03-30 19:41:33 PDT
Chrome has a similar bug and a patch in the process
https://bugs.chromium.org/p/chromium/issues/detail?id=626293
Comment 3 karl 2017-03-30 19:42:21 PDT
This was also opened as a Web Compatibility issue on 
https://webcompat.com/issues/5335
Comment 4 Ahmad Saleem 2023-10-28 17:31:39 PDT
Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

in 'generatesLineBoxesForInlineChild' function:

if (child.hasNonVisibleOverflow())
           break;

___

Fixes and start showing 'bullets' but mess-up whole alignment. So there is more to do and also it leads to two more WPT failures.
Comment 5 Ahmad Saleem 2023-10-28 17:32:37 PDT
WPT failures:

imported/w3c/web-platform-tests/css/css-lists/list-and-block-textarea-001.html [ Failure ]
  imported/w3c/web-platform-tests/css/css-lists/list-and-margin-collapse-001.html [ Failure ]
Comment 6 Karl Dubost 2023-10-30 13:28:54 PDT
Ahmad,
Chrome fixed it in getParentOfFirstLineBox(), not generatesLineBoxesForInlineChild()


which in WebKit is
https://searchfox.org/wubkat/rev/5fb255b53fc547d77ec57e9d2d59b9cb8762d59b/Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#46-73

Is it what you tried?
Comment 7 Ahmad Saleem 2023-10-30 13:30:40 PDT
(In reply to Karl Dubost from comment #6)
> Ahmad,
> Chrome fixed it in getParentOfFirstLineBox(), not
> generatesLineBoxesForInlineChild()
> 
> 
> which in WebKit is
> https://searchfox.org/wubkat/rev/5fb255b53fc547d77ec57e9d2d59b9cb8762d59b/
> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#46-73
> 
> Is it what you tried?

Yes - I think I copied the wrong function name but 'getParentOfFirstLineBox', was where I applied this patch.
Comment 8 Radar WebKit Bug Importer 2024-02-08 15:42:07 PST
<rdar://problem/122588183>