Bug 73004 - DRT isn't updating on chromium linux build.webkit.org bot
Summary: DRT isn't updating on chromium linux build.webkit.org bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 23:10 PST by Dirk Pranke
Modified: 2011-11-22 23:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.22 KB, patch)
2011-11-22 23:12 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-11-22 23:10:47 PST
There appears to be a bug in the Makefile generator for GYP that is causing the chromium linux build on build.webkit.org to not include DRT in the "all" target; the issue seems to be that the DRT target is being resolved two different ways, leading to the DumpRenderTree.target.chromium.mk file getting generated twice; the second time is not pulled in from WebKit.gyp, so it isn't considered to be part of the "all" target.

The bug was introduced with the change in chromium r111360 to enable appcache and content to be build as DLLs (this introduced a dependency on WebKit.gyp to the appcache target, causing the problem).
Comment 1 Dirk Pranke 2011-11-22 23:12:39 PST
Created attachment 116322 [details]
Patch
Comment 2 Dirk Pranke 2011-11-22 23:13:17 PST
Committed r101044: <http://trac.webkit.org/changeset/101044>