Bug 72998 - WebIDL: Add support for static for JSC and V8
Summary: WebIDL: Add support for static for JSC and V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL: http://www.w3.org/TR/WebIDL/#idl-stat...
Keywords:
Depends on: 73342
Blocks: 71968 73365
  Show dependency tree / graph
 
Reported: 2011-11-22 18:19 PST by Erik Arvidsson
Modified: 2011-11-29 16:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (19.19 KB, patch)
2011-11-29 14:38 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch (19.21 KB, patch)
2011-11-29 14:48 PST, Erik Arvidsson 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2011-11-22 18:19:38 PST 
http://www.w3.org/TR/WebIDL/#idl-static-operations

We need to add support for static to be able to correctly implement the URL object.

Our implementation of the URL object is flawed. window.webkitURL returns an instance of DOMURL when it should return a URL constructor.

http://www.w3.org/TR/FileAPI/#URL-object
Comment 1 Erik Arvidsson 2011-11-28 12:02:24 PST 
It turns out that CodeGeneratorV8.pm already supports this using [ClassMethod]

I plan to change the code generator to use "static" instead but a as a first step I am going to make CodeGeneratorJS support [ClassMethod] too.
Comment 2 Erik Arvidsson 2011-11-29 14:38:26 PST 
Created attachment 117047 [details]
Patch
Comment 3 Erik Arvidsson 2011-11-29 14:48:01 PST 
Created attachment 117048 [details]
Patch
Comment 4 Erik Arvidsson 2011-11-29 16:40:41 PST 
webkit-patch land failed

Commited as

http://trac.webkit.org/changeset/101433