Bug 72975 - UString methods are not character size aware
: UString methods are not character size aware
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-22 10:58 PST by
Modified: 2011-11-24 22:55 PST (History)


Attachments
Patch (4.67 KB, patch)
2011-11-22 11:07 PST, Michael Saboff
fpizlo: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-22 10:58:26 PST
Various UString methods do not take into account the character size of their arguments.  Also the constructors that convert numbers to strings create 16 bit strings.
------- Comment #1 From 2011-11-22 11:07:24 PST -------
Created an attachment (id=116252) [details]
Patch
------- Comment #2 From 2011-11-24 11:10:15 PST -------
(From update of attachment 116252 [details])
What is the performance effect, if any?
------- Comment #3 From 2011-11-24 22:55:14 PST -------
(In reply to comment #2)
> (From update of attachment 116252 [details] [details])
> What is the performance effect, if any?

This change appears neutral on SunSpider.  Together with other changes it provides a benefit on SunSpider.
------- Comment #4 From 2011-11-24 22:55:52 PST -------
Committed r101152: <http://trac.webkit.org/changeset/101152>