Bug 72970 – Add WTF infrastructure for the BlackBerry port

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Daniel Bates]

Towards getting JavaScriptCore building for the BlackBerry port we need to add some BlackBerry-specific code for threading, assertions, random number seed generation, and strings.

We also need to add a some quirks to wtf/MathExtras.h due to differences between the GNU and QNX C++ headers. We'll look to follow up and remove these quirks.

[Daniel Bates]

PR 118379

[Daniel Bates]

Created attachment 116250 [details]
Patch

[WebKit Review Bot]

Attachment 116250 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/text/WTFString.h:52:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

(In reply to comment #3)
> Attachment 116250 [details] did not pass style-queue:
> [...]
> Source/JavaScriptCore/wtf/text/WTFString.h:52:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> Total errors found: 1 in 8 files

From my understanding of reading (3) of section Indentation on <http://www.webkit.org/coding/coding-style.html>, the contents of a nested namespace should be indented.

[David Levin]

(In reply to comment #4)
> (In reply to comment #3)
> > Attachment 116250 [details] [details] did not pass style-queue:
> > [...]
> > Source/JavaScriptCore/wtf/text/WTFString.h:52:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> > Total errors found: 1 in 8 files
> 
> From my understanding of reading (3) of section Indentation on <http://www.webkit.org/coding/coding-style.html>, the contents of a nested namespace should be indented.

Sounds right. No one has implemented this subcase of the check yet.

[Daniel Bates]

Comment on attachment 116250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116250&action=review

> Source/JavaScriptCore/wtf/RandomNumberSeed.h:59
> +#elif OS(UNIX) && !PLATFORM(BLACKBERRY)

I spoke with Antonio Gomes on IRC about this change. We may be able to use the UNIX code path. I'll look into this some more and follow up if needed.

[Daniel Bates]

Committed r101041: <http://trac.webkit.org/changeset/101041>

[Antonio Gomes]

(In reply to comment #6)
> (From update of attachment 116250 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116250&action=review
> 
> > Source/JavaScriptCore/wtf/RandomNumberSeed.h:59
> > +#elif OS(UNIX) && !PLATFORM(BLACKBERRY)
> 
> I spoke with Antonio Gomes on IRC about this change. We may be able to use the UNIX code path. I'll look into this some more and follow up if needed.

filed bug 73028 about it.