Bug 72969 - Array.toString always uses StringImpl::characters()
Summary: Array.toString always uses StringImpl::characters()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 72968
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 10:32 PST by Michael Saboff
Modified: 2011-11-25 22:08 PST (History)
0 users

See Also:


Attachments
Patch (2.34 KB, patch)
2011-11-24 23:10 PST, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-11-22 10:32:24 PST
arrayProtoFuncToString should determine the element's toString size and if all are 8 bit, then the results should be constructed as an 8 bit string.
Comment 1 Michael Saboff 2011-11-24 23:10:06 PST
Created attachment 116566 [details]
Patch
Comment 2 Filip Pizlo 2011-11-25 21:34:09 PST
Comment on attachment 116566 [details]
Patch

Can you put the performance effect in the ChangeLog (even if it's neutral).
Comment 3 Michael Saboff 2011-11-25 22:08:46 PST
Committed r101186: <http://trac.webkit.org/changeset/101186>