Bug 72958 - CSSStyleDeclaration: Kill FIXME in setProperty().
Summary: CSSStyleDeclaration: Kill FIXME in setProperty().
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-11-22 07:28 PST by Andreas Kling
Modified: 2011-11-22 09:40 PST (History)
2 users (show)

See Also:

Patch (1.61 KB, patch)
2011-11-22 07:32 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-22 07:28:49 PST
The current behavior of setProperty() to not throw exceptions for invalid property names is correct as specified by CSSOM ( http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty ), so we can remove the FIXME about throwing an exception for that case.
Comment 1 Andreas Kling 2011-11-22 07:32:22 PST
Created attachment 116225 [details]
Comment 2 Antonio Gomes 2011-11-22 07:50:22 PST
Comment on attachment 116225 [details]

If you really want you could even add a test to be sure we do not throw an exception when we set a invalid property :-)
Comment 3 WebKit Review Bot 2011-11-22 09:40:10 PST
Comment on attachment 116225 [details]

Clearing flags on attachment: 116225

Committed r101007: <http://trac.webkit.org/changeset/101007>
Comment 4 WebKit Review Bot 2011-11-22 09:40:14 PST
All reviewed patches have been landed.  Closing bug.