RESOLVED FIXED72956
[chromium] Drop root layer tiles on platforms that cache the front buffer 
https://bugs.webkit.org/show_bug.cgi?id=72956
Summary [chromium] Drop root layer tiles on platforms that cache the front buffer
Jonathan Backer
Reported 2011-11-22 06:56:06 PST
[chromium] NOT FOR REVIEW Drop root layer tiles on platforms that cache the front buffer
Attachments
Patch (5.19 KB, patch)
2011-11-22 06:57 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2011-11-22 07:00 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2011-11-23 12:17 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2011-11-23 12:23 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Backer
Comment 1 2011-11-22 06:57:55 PST
Created attachment 116220 [details] Patch
Jonathan Backer
Comment 2 2011-11-22 07:00:45 PST
Created attachment 116222 [details] Patch
Jonathan Backer
Comment 3 2011-11-22 07:04:53 PST
nduca: Can you PTAL?
Jonathan Backer
Comment 4 2011-11-22 07:05:39 PST
Chromium side here: http://codereview.chromium.org/8637014/ Because of the extension mechanism, they can land independently.
Jonathan Backer
Comment 5 2011-11-23 12:17:58 PST
Created attachment 116394 [details] Patch
Jonathan Backer
Comment 6 2011-11-23 12:23:43 PST
Created attachment 116396 [details] Patch
Adrienne Walker
Comment 7 2011-11-23 13:18:41 PST
Comment on attachment 116396 [details] Patch This looks good to me.
Kenneth Russell
Comment 8 2011-11-23 13:43:48 PST
Comment on attachment 116396 [details] Patch Thanks enne. r=me
Kenneth Russell
Comment 9 2011-11-23 13:49:33 PST
Comment on attachment 116396 [details] Patch cq+'ing on backer's offline request.
WebKit Review Bot
Comment 10 2011-11-23 14:48:58 PST
Comment on attachment 116396 [details] Patch Clearing flags on attachment: 116396 Committed r101104: <http://trac.webkit.org/changeset/101104>
WebKit Review Bot
Comment 11 2011-11-23 14:49:03 PST
All reviewed patches have been landed. Closing bug.
Nat Duca
Comment 12 2011-12-01 21:32:42 PST
This patch stashes a bool discardAllTextures on the CCSettings struct, which is a misuse of the CCSettings struct, or i'm misunderstanding its purpose. Afaict, the discardAllTextures really is just a cached value of LayerRendererCapabilities::usingFrontBufferCached. CCSettings is a struct that exposes "compositor features" to embedders of the compositor API. This is not a public feature. LayerRendererCapabilities is available on both the impl thread an the main thread. From CCLayerTreeHost, you can efficiently obtain the capabilities with m_proxy->layerRendererCapabilities(). Also, the variable names here are massively inconsistent. I would love the capabilities bit to be contextHasCachedFrontBuffer or contextSupportsFrontBufferCached. Sorry I didn't catch this in the previous codereview. /me was out sick.
Note You need to log in before you can comment on or make changes to this bug.