Bug 72956 - [chromium] Drop root layer tiles on platforms that cache the front buffer
Summary: [chromium] Drop root layer tiles on platforms that cache the front buffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 06:56 PST by Jonathan Backer
Modified: 2011-12-01 21:32 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.19 KB, patch)
2011-11-22 06:57 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2011-11-22 07:00 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2011-11-23 12:17 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2011-11-23 12:23 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Backer 2011-11-22 06:56:06 PST
[chromium] NOT FOR REVIEW Drop root layer tiles on platforms that cache the front buffer
Comment 1 Jonathan Backer 2011-11-22 06:57:55 PST
Created attachment 116220 [details]
Patch
Comment 2 Jonathan Backer 2011-11-22 07:00:45 PST
Created attachment 116222 [details]
Patch
Comment 3 Jonathan Backer 2011-11-22 07:04:53 PST
nduca: Can you PTAL?
Comment 4 Jonathan Backer 2011-11-22 07:05:39 PST
Chromium side here: http://codereview.chromium.org/8637014/

Because of the extension mechanism, they can land independently.
Comment 5 Jonathan Backer 2011-11-23 12:17:58 PST
Created attachment 116394 [details]
Patch
Comment 6 Jonathan Backer 2011-11-23 12:23:43 PST
Created attachment 116396 [details]
Patch
Comment 7 Adrienne Walker 2011-11-23 13:18:41 PST
Comment on attachment 116396 [details]
Patch

This looks good to me.
Comment 8 Kenneth Russell 2011-11-23 13:43:48 PST
Comment on attachment 116396 [details]
Patch

Thanks enne. r=me
Comment 9 Kenneth Russell 2011-11-23 13:49:33 PST
Comment on attachment 116396 [details]
Patch

cq+'ing on backer's offline request.
Comment 10 WebKit Review Bot 2011-11-23 14:48:58 PST
Comment on attachment 116396 [details]
Patch

Clearing flags on attachment: 116396

Committed r101104: <http://trac.webkit.org/changeset/101104>
Comment 11 WebKit Review Bot 2011-11-23 14:49:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Nat Duca 2011-12-01 21:32:42 PST
This patch stashes a bool discardAllTextures on the CCSettings struct, which is a misuse of the CCSettings struct, or i'm misunderstanding its purpose.

Afaict, the discardAllTextures really is just a cached value of LayerRendererCapabilities::usingFrontBufferCached.

CCSettings is a struct that exposes "compositor features" to embedders of the compositor API. This is not a public feature.

LayerRendererCapabilities is available on both the impl thread an the main thread. From CCLayerTreeHost, you can efficiently obtain the capabilities with m_proxy->layerRendererCapabilities().

Also, the variable names here are massively inconsistent. I would love the capabilities bit to be contextHasCachedFrontBuffer or contextSupportsFrontBufferCached.

Sorry I didn't catch this in the previous codereview. /me was out sick.