fast/loader/non-deferred-substitute-load.html was crashed on the debug version of DRT Chromium port. The crash was caused by ASSERT(!newRequest.isNull()) in MainResourceLoader::willSendRequest. After investigation, test non-deferred-substitute-load.html calls LayoutTestController::queueLoadHTMLString to load some HTML contents, however DRT Chromium port sets a empty URL as default base URL in LayoutTestController::queueLoadHTMLString, which causes the assert. By looking at the general DRT implementation, (see http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/LayoutTestController.cpp#L1016.) it sets a "" string as default value to baseURL to avoid the assert, DRT Chromium port should follow it. A patch is on the way
Created attachment 116216 [details] patch v1
Comment on attachment 116216 [details] patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=116216&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:575 > + // FIXME: Should use the URL of current document as default if it is specified? Nit: I would remove this comment since it seems like this is intentional.
Created attachment 116307 [details] patch v1 with addressing tony's nit.
Comment on attachment 116307 [details] patch v1 with addressing tony's nit. Clearing flags on attachment: 116307 Committed r101076: <http://trac.webkit.org/changeset/101076>
All reviewed patches have been landed. Closing bug.