Bug 72940 - A test that mutation happens when asynchronous spell checking is in process.
Summary: A test that mutation happens when asynchronous spell checking is in process.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 74479 71991
  Show dependency tree / graph
 
Reported: 2011-11-22 04:49 PST by Shinya Kawanaka
Modified: 2011-12-18 23:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.55 KB, patch)
2011-12-14 21:54 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (11.27 KB, patch)
2011-12-15 19:39 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (11.29 KB, patch)
2011-12-18 21:42 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2011-11-22 04:49:40 PST 
A test that mutation happens in asynchronous spellchecking lacks.
This is required.
Comment 1 Shinya Kawanaka 2011-12-14 21:54:51 PST 
Created attachment 119373 [details]
Patch
Comment 2 Hajime Morrita 2011-12-15 02:37:05 PST 
Comment on attachment 119373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119373&action=review

Could you check actual marker existence?

> LayoutTests/editing/spelling/spellcheck-async-mutation.html:125
> +    function selectAll(elem) {

It doesn't look to select all.
Comment 3 Shinya Kawanaka 2011-12-15 19:39:25 PST 
Created attachment 119544 [details]
Patch
Comment 4 Shinya Kawanaka 2011-12-15 19:42:32 PST 
(In reply to comment #2)
> (From update of attachment 119373 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119373&action=review
> 
> Could you check actual marker existence?

Done.
In 'move', markers are there on the original (moved) element
In 'mutate', marker disappears as expected.

In 'mutate', I've changed "zz, zz, zz" to "zzz". So the first "zz" are the same, we afraid that "zz" might be marked. But that case didn't happen.

> 
> > LayoutTests/editing/spelling/spellcheck-async-mutation.html:125
> > +    function selectAll(elem) {
> 
> It doesn't look to select all.

Done.
Comment 5 WebKit Review Bot 2011-12-16 01:05:06 PST 
Comment on attachment 119544 [details]
Patch

Clearing flags on attachment: 119544

Committed r103044: <http://trac.webkit.org/changeset/103044>
Comment 6 WebKit Review Bot 2011-12-16 01:05:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Hajime Morrita 2011-12-16 03:10:46 PST 
Reverted r103044 for reason:

Added test doesn't pass on Mac SL and Mac Chromium

Committed r103053: <http://trac.webkit.org/changeset/103053>
Comment 8 Hajime Morrita 2011-12-16 03:13:32 PST 
This isn't  real failure but 
the timing when "TEST COMPLETE" is printed was different between Mac, Chromium/Mac and others.
We need to find the way to stabilize it.
Comment 9 Shinya Kawanaka 2011-12-18 21:42:35 PST 
Created attachment 119812 [details]
Patch
Comment 10 Shinya Kawanaka 2011-12-18 21:43:02 PST 
(In reply to comment #9)
> Created an attachment (id=119812) [details]
> Patch

This is a try to stabilize the test.
Comment 11 WebKit Review Bot 2011-12-18 23:00:10 PST 
Comment on attachment 119812 [details]
Patch

Clearing flags on attachment: 119812

Committed r103220: <http://trac.webkit.org/changeset/103220>
Comment 12 WebKit Review Bot 2011-12-18 23:00:15 PST 
All reviewed patches have been landed.  Closing bug.