WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72937
Web Inspector: remove Inspector::bringToFront from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=72937
Summary
Web Inspector: remove Inspector::bringToFront from the protocol.
Pavel Feldman
Reported
2011-11-22 04:03:05 PST
Inspector::bringToFront protocol method is currently used on the backend in order to reveal the front-end window. We should do that by means of the inspector client interface instead.
Attachments
Patch
(23.46 KB, patch)
2011-11-22 04:10 PST
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-11-22 04:10:55 PST
Created
attachment 116198
[details]
Patch
Yury Semikhatsky
Comment 2
2011-11-22 04:27:28 PST
Comment on
attachment 116198
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116198&action=review
> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:79 > + InspectorFrontendClient* m_frontendClient;
m_frontendClient initialization is missing in the constructor.
Pavel Feldman
Comment 3
2011-11-22 06:12:07 PST
Committed
r100995
: <
http://trac.webkit.org/changeset/100995
>
Timothy Hatcher
Comment 4
2011-11-22 07:08:29 PST
Comment on
attachment 116198
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116198&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp:47 > + ASSERT(m_page->inspector()->createInspectorPage());
This is wrong! This will not compile in Release builds. Please fix immediately by putting on two lines.
Pavel Feldman
Comment 5
2011-11-22 07:18:37 PST
> This is wrong! This will not compile in Release builds. Please fix immediately by putting on two lines.
Committed
r101001
. Thanks for the heads up.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug