Bug 72937 - Web Inspector: remove Inspector::bringToFront from the protocol.
: Web Inspector: remove Inspector::bringToFront from the protocol.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 04:03 PST by Pavel Feldman
Modified: 2011-11-22 07:18 PST (History)
12 users (show)

See Also:


Attachments
Patch (23.46 KB, patch)
2011-11-22 04:10 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-22 04:03:05 PST
Inspector::bringToFront protocol method is currently used on the backend in order to reveal the front-end window. We should do that by means of the inspector client interface instead.
Comment 1 Pavel Feldman 2011-11-22 04:10:55 PST
Created attachment 116198 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-22 04:27:28 PST
Comment on attachment 116198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116198&action=review

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:79
> +    InspectorFrontendClient* m_frontendClient;

m_frontendClient initialization is missing in the constructor.
Comment 3 Pavel Feldman 2011-11-22 06:12:07 PST
Committed r100995: <http://trac.webkit.org/changeset/100995>
Comment 4 Timothy Hatcher 2011-11-22 07:08:29 PST
Comment on attachment 116198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116198&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp:47
> +    ASSERT(m_page->inspector()->createInspectorPage());

This is wrong! This will not compile in Release builds. Please fix immediately by putting on two lines.
Comment 5 Pavel Feldman 2011-11-22 07:18:37 PST
> This is wrong! This will not compile in Release builds. Please fix immediately by putting on two lines.

Committed r101001. Thanks for the heads up.