Bug 72920 - Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
Summary: Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 17:32 PST by Vsevolod Vlasov
Modified: 2011-11-22 05:25 PST (History)
10 users (show)

See Also:


Attachments
Patch (59.86 KB, patch)
2011-11-21 17:37 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-11-21 17:32:56 PST
Extract SplitView from Panel.createSidebar() methodand reuse in Elements and Scripts panels.
Comment 1 Vsevolod Vlasov 2011-11-21 17:37:28 PST
Created attachment 116156 [details]
Patch
Comment 2 Pavel Feldman 2011-11-22 01:11:57 PST
Comment on attachment 116156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116156&action=review

Please test this thoroughly prior to landing.

> Source/WebCore/inspector/front-end/ElementsPanel.js:42
> +    this.createSplitView(this.element, WebInspector.SplitView.SidebarPosition.Right, 325);

Please introduce explicit named "const initialSidebarWidth = 325;" above this line.

> Source/WebCore/inspector/front-end/ElementsPanel.js:44
> +    this.splitView.minimalMainWidthPercent = 34;

ditto

> Source/WebCore/inspector/front-end/Panel.js:125
> +     * @param {string=} position

You can try using "enum" type annotation.

> Source/WebCore/inspector/front-end/SplitView.js:43
> +    this.leftElement = document.createElement("div");

You could probably make some of these private.
Comment 3 Vsevolod Vlasov 2011-11-22 05:25:08 PST
Committed r100991: <http://trac.webkit.org/changeset/100991>