RESOLVED FIXED 72920
Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels. 
https://bugs.webkit.org/show_bug.cgi?id=72920
Summary Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse ...
Vsevolod Vlasov
Reported 2011-11-21 17:32:56 PST
Extract SplitView from Panel.createSidebar() methodand reuse in Elements and Scripts panels.
Attachments
Patch (59.86 KB, patch)
2011-11-21 17:37 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-11-21 17:37:28 PST
Created attachment 116156 [details] Patch
Pavel Feldman
Comment 2 2011-11-22 01:11:57 PST
Comment on attachment 116156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116156&action=review Please test this thoroughly prior to landing. > Source/WebCore/inspector/front-end/ElementsPanel.js:42 > + this.createSplitView(this.element, WebInspector.SplitView.SidebarPosition.Right, 325); Please introduce explicit named "const initialSidebarWidth = 325;" above this line. > Source/WebCore/inspector/front-end/ElementsPanel.js:44 > + this.splitView.minimalMainWidthPercent = 34; ditto > Source/WebCore/inspector/front-end/Panel.js:125 > + * @param {string=} position You can try using "enum" type annotation. > Source/WebCore/inspector/front-end/SplitView.js:43 > + this.leftElement = document.createElement("div"); You could probably make some of these private.
Vsevolod Vlasov
Comment 3 2011-11-22 05:25:08 PST
Committed r100991: <http://trac.webkit.org/changeset/100991>
Note You need to log in before you can comment on or make changes to this bug.