Bug 72914 - [Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
Summary: [Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-11-21 14:59 PST by Jesus Sanchez-Palencia
Modified: 2011-11-23 14:05 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.50 KB, patch)
2011-11-21 15:03 PST, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2011-11-21 14:59:39 PST
"[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental"
Comment 1 Jesus Sanchez-Palencia 2011-11-21 15:03:57 PST
Created attachment 116143 [details]
Patch
Comment 2 Andreas Kling 2011-11-23 09:04:31 PST
Comment on attachment 116143 [details]
Patch

rs=mø
Comment 3 WebKit Review Bot 2011-11-23 09:06:55 PST
Comment on attachment 116143 [details]
Patch

Rejecting attachment 116143 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
UIProcess/API/qt/tests/qmltests/common/download.html'
patching file Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.rej
patching file Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
Hunk #1 succeeded at 834 (offset -84 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/10607356
Comment 4 Jesus Sanchez-Palencia 2011-11-23 14:04:20 PST
Committed r101103: <http://trac.webkit.org/changeset/101103>