Test the canvas/philip test suite with GPU acceleration, without a separate pass
Created attachment 116142 [details] Patch
Comment on attachment 116142 [details] Patch Attachment 116142 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10569070
Attachment 116142 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/gpu/..." exit_code: 1 Last 3072 characters of output: /chromium/test_expectations.txt:2106: Path does not exist. gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2107: Path does not exist. gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2108: Path does not exist. gpu/canvas/philip/tests/2d.gradient.radial.outside3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2109: Path does not exist. gpu/canvas/philip/tests/2d.gradient.radial.touch1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2110: Path does not exist. gpu/canvas/philip/tests/2d.gradient.radial.touch3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2111: Path does not exist. gpu/canvas/philip/tests/2d.path.arc.angle.3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2112: Path does not exist. gpu/canvas/philip/tests/2d.path.arc.angle.5.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2113: Path does not exist. gpu/canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2114: Path does not exist. gpu/canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2115: Path does not exist. gpu/canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2116: Path does not exist. gpu/canvas/philip/tests/2d.shadow.canvas.basic.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2117: Path does not exist. gpu/canvas/philip/tests/2d.shadow.canvas.transparent.2.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2118: Path does not exist. gpu/canvas/philip/tests/2d.shadow.image.alpha.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2119: Path does not exist. gpu/canvas/philip/tests/2d.shadow.image.basic.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2120: Path does not exist. gpu/canvas/philip/tests/2d.shadow.image.scale.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2121: Path does not exist. gpu/canvas/philip/tests/2d.shadow.image.transparent.2.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:2122: Path does not exist. gpu/canvas/philip/tests/type.prototype.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3528: Path does not exist. gpu/canvas/philip/tests/2d.shadow.canvas.alpha.html [test/expectations] [2] LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 61 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Looks like the symlinks didn't make it through webkit-patch. So either I'll need to make a copy of the entire test suite, or trust that symlinks will work on commit. I'll try uploading the former, just to see if it makes it past the EWS bots.
Created attachment 116255 [details] Patch
Created attachment 116263 [details] update to r101021
Comment on attachment 116263 [details] update to r101021 Attachment 116263 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10607003
I'm not too happy with this patch, since 1) It seems to require copying the entire canvas/philip test suite (symlinks don't work, at least through webkit-patch; maybe it will work at svn commit time though). 2) It requires duplication of the test_expectations.txt lines which fail on both GPU and non-GPU paths (~70 lines). The suite should also should probably be dup'ed into LayoutTests/platform/chromium/gpu, rather than LayoutTests/gpu, so as to avoid inflicting this extra work at DRT run time on other ports. Finally, I'm not sure what's going on with gtk/win build errors.
I think I'd prefer to do some sort of copy-by-reference scheme, perhaps by teaching DumpRenderTree and new-run-webkit-tests about a virtual directory that ran the canvas/philip/tests suite with a different set of flags
I would prefer to avoid cloning the directory as well, so I also would like some sort of "virtual directory" scheme as James has suggested. I will see if I can come up with some sort of proposal in the next week or two.
Dirk has successfully implemented the virtual/gpu testing infrastructure he described, so this change is obsolete.