RESOLVED FIXED 72911
Roll Chromium DEPS to last-known good revision 
https://bugs.webkit.org/show_bug.cgi?id=72911
Summary Roll Chromium DEPS to last-known good revision
WebKit Review Bot
Reported 2011-11-21 13:54:53 PST
A DEPS roll a day keeps the build break away.
Attachments
Patch (942 bytes, patch)
2011-11-21 13:55 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
update to actual version, and add dbus dep (1.36 KB, patch)
2011-11-21 13:58 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
guessing at cause of gyp error (1.54 KB, patch)
2011-11-21 14:17 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
perhaps remove cycle in gyp loading? (1.66 KB, patch)
2011-11-21 15:41 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
roll deps part way, with hack for ppapi dep on nacl (1.75 KB, patch)
2011-11-21 19:03 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
Modified patch that will pull in native_client/build properly. (2.23 KB, patch)
2011-11-21 19:42 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix rev to 110359 instead to miss appcache component issues (2.23 KB, patch)
2011-11-21 19:46 PST, Dirk Pranke 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-11-21 13:55:06 PST
Created attachment 116130 [details] Patch
Scott Graham
Comment 2 2011-11-21 13:58:58 PST
Created attachment 116131 [details] update to actual version, and add dbus dep
Scott Graham
Comment 3 2011-11-21 14:17:45 PST
Created attachment 116135 [details] guessing at cause of gyp error
Scott Graham
Comment 4 2011-11-21 15:41:15 PST
Created attachment 116152 [details] perhaps remove cycle in gyp loading?
WebKit Review Bot
Comment 5 2011-11-21 16:29:27 PST
Comment on attachment 116152 [details] perhaps remove cycle in gyp loading? Attachment 116152 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10559022
Scott Graham
Comment 6 2011-11-21 19:03:28 PST
Created attachment 116166 [details] roll deps part way, with hack for ppapi dep on nacl
Scott Graham
Comment 7 2011-11-21 19:12:40 PST
(Dirk thinks he may have a better solution for the NaCl business)
Dirk Pranke
Comment 8 2011-11-21 19:39:05 PST
Comment on attachment 116166 [details] roll deps part way, with hack for ppapi dep on nacl I really doubt we want to have an overriding native_client/build/untrusted.gypi file here ... I'll post a modified version of this that will pull in the native_client/build dir, which is only 512k. Unfortunately that means we may have to track the native_client revisions as well, since I don't think there is a way to say (roll to whatever version of NaCl that the chromium DEPS is using).
Dirk Pranke
Comment 9 2011-11-21 19:42:40 PST
Created attachment 116169 [details] Modified patch that will pull in native_client/build properly.
Dirk Pranke
Comment 10 2011-11-21 19:46:25 PST
Created attachment 116170 [details] fix rev to 110359 instead to miss appcache component issues
Dirk Pranke
Comment 11 2011-11-21 19:51:37 PST
The patch for the webkit_appcache.gypi issue is here: http://codereview.chromium.org/8636003/ . If the try jobs pass, I will try to land this tonight and then you'll have to roll chromium to the latest rev for things to work again. Sorry for the breakage; I should've tested the webkit.org chromium bots and done a roll earlier myself.
WebKit Review Bot
Comment 12 2011-11-21 20:10:05 PST
Comment on attachment 116170 [details] fix rev to 110359 instead to miss appcache component issues Attachment 116170 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10555088
Dirk Pranke
Comment 13 2011-11-22 10:30:30 PST
Committed r101011: <http://trac.webkit.org/changeset/101011>
Tony Chang
Comment 14 2011-12-02 10:00:55 PST
Comment on attachment 116170 [details] fix rev to 110359 instead to miss appcache component issues Already committed.
Note You need to log in before you can comment on or make changes to this bug.