Bug 72899 – Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

This removed all inspector notification methods in favor of using events.

[Andrey Kosyakov]

Created attachment 116107 [details]
Patch

[WebKit Review Bot]

Comment on attachment 116107 [details]
Patch

Attachment 116107 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10393435

New failing tests:
inspector/extensions/extensions-events.html

[Pavel Feldman]

Comment on attachment 116107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116107&action=review

> Source/WebCore/inspector/front-end/ExtensionServer.js:526
> +        this._registerAutosubscriptionHandler("panel-objectSelected-elements",

Could you introduce the constants for these?

> Source/WebCore/inspector/front-end/Resource.js:865
> +        WebInspector.Resource.notifications.dispatchEventToListeners(WebInspector.Resource.Events.ResourceContentCommitted, { resource: this, content: newContent });

Could you please dispatch this event on the resource tree model instead?

[Andrey Kosyakov]

Created attachment 116204 [details]
Patch

[Andrey Kosyakov]

- use constants for command and event names
- dispatch ResourceContentCommitted on WebInspector.resourceTreeModel, not on WebInspector.Resource.notifications()

[Pavel Feldman]

Comment on attachment 116204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116204&action=review

> Source/WebCore/inspector/front-end/Resource.js:255
> +    ResourceContentCommitted: "resource-content-committed"

You should move this to the tree model event list.

[Andrey Kosyakov]

Committed r100994: <http://trac.webkit.org/changeset/100994>