Bug 72899 - Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
Summary: Web Inspector: [Extensions API][refactoring] remove dependencies on the Exten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 10:51 PST by Andrey Kosyakov
Modified: 2011-11-22 05:41 PST (History)
12 users (show)

See Also:


Attachments
Patch (7.12 KB, patch)
2011-11-21 10:53 PST, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (30.71 KB, patch)
2011-11-22 04:32 PST, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-11-21 10:51:33 PST
This removed all inspector notification methods in favor of using events.
Comment 1 Andrey Kosyakov 2011-11-21 10:53:50 PST
Created attachment 116107 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-21 11:49:12 PST
Comment on attachment 116107 [details]
Patch

Attachment 116107 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10393435

New failing tests:
inspector/extensions/extensions-events.html
Comment 3 Pavel Feldman 2011-11-22 00:59:25 PST
Comment on attachment 116107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116107&action=review

> Source/WebCore/inspector/front-end/ExtensionServer.js:526
> +        this._registerAutosubscriptionHandler("panel-objectSelected-elements",

Could you introduce the constants for these?

> Source/WebCore/inspector/front-end/Resource.js:865
> +        WebInspector.Resource.notifications.dispatchEventToListeners(WebInspector.Resource.Events.ResourceContentCommitted, { resource: this, content: newContent });

Could you please dispatch this event on the resource tree model instead?
Comment 4 Andrey Kosyakov 2011-11-22 04:32:52 PST
Created attachment 116204 [details]
Patch
Comment 5 Andrey Kosyakov 2011-11-22 04:33:59 PST
- use constants for command and event names
- dispatch ResourceContentCommitted on WebInspector.resourceTreeModel, not on WebInspector.Resource.notifications()
Comment 6 Pavel Feldman 2011-11-22 05:03:02 PST
Comment on attachment 116204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116204&action=review

> Source/WebCore/inspector/front-end/Resource.js:255
> +    ResourceContentCommitted: "resource-content-committed"

You should move this to the tree model event list.
Comment 7 Andrey Kosyakov 2011-11-22 05:41:21 PST
Committed r100994: <http://trac.webkit.org/changeset/100994>