Bug 72895 - [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
Summary: [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 09:36 PST by Dominic Mazzoni
Modified: 2011-11-21 13:04 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.81 KB, patch)
2011-11-21 09:49 PST, Dominic Mazzoni
no flags Details | Formatted Diff | Diff
Patch for landing (9.81 KB, patch)
2011-11-21 11:35 PST, Dominic Mazzoni
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2011-11-21 09:36:03 PST
Instead of a switch statement, a WebCore::AXObjectCache::AXNotification can be converted to a WebAccessibilityNotification with a simple cast, checked by AssertMatchingEnums.cpp.
Comment 1 Dominic Mazzoni 2011-11-21 09:49:44 PST
Created attachment 116102 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-21 09:53:58 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 chris fleizach 2011-11-21 11:13:53 PST
Comment on attachment 116102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116102&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:598
> +        notificationName = "MenuListValueItemSelected";

The actual value is named differently than the enum
Comment 4 chris fleizach 2011-11-21 11:16:24 PST
Comment on attachment 116102 [details]
Patch

Otherwise looks ok.
Comment 5 Darin Fisher (:fishd, Google) 2011-11-21 11:22:09 PST
Comment on attachment 116102 [details]
Patch

Cool, LGTM
Comment 6 Dominic Mazzoni 2011-11-21 11:35:07 PST
Created attachment 116111 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-11-21 13:04:20 PST
Comment on attachment 116111 [details]
Patch for landing

Clearing flags on attachment: 116111

Committed r100948: <http://trac.webkit.org/changeset/100948>
Comment 8 WebKit Review Bot 2011-11-21 13:04:24 PST
All reviewed patches have been landed.  Closing bug.