Bug 72886 - Web Inspector: strip unused InspectorController methods.
Summary: Web Inspector: strip unused InspectorController methods.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 07:52 PST by Pavel Feldman
Modified: 2011-11-22 01:52 PST (History)
13 users (show)

See Also:


Attachments
Patch (27.71 KB, patch)
2011-11-21 08:04 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] with GTK bot fixed. (29.28 KB, patch)
2011-11-21 10:09 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-21 07:52:38 PST
This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=63009. I am now able to remove following InspectorController methods:
::startUserInitiatedProfiling,
::isRecordingUserInitiatedProfile,
::stopUserInitiatedProfiling,
::showAndEnableDebugger,
::debuggerEnabled,
::disableDebugger,
::startTimelineProfiler,
::stopTimelineProfiler,
::timelineProfilerEnabled,
::showConsole.
Comment 1 Pavel Feldman 2011-11-21 08:04:15 PST
Created attachment 116090 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-21 08:09:13 PST
Comment on attachment 116090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116090&action=review

> Source/WebCore/inspector/InspectorController.h:109
> +

Remove this line.
Comment 3 Collabora GTK+ EWS bot 2011-11-21 08:15:11 PST
Comment on attachment 116090 [details]
Patch

Attachment 116090 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10534283
Comment 4 Pavel Feldman 2011-11-21 10:09:09 PST
Created attachment 116103 [details]
[Patch] with GTK bot fixed.
Comment 5 Yury Semikhatsky 2011-11-22 00:45:18 PST
Comment on attachment 116103 [details]
[Patch] with GTK bot fixed.

View in context: https://bugs.webkit.org/attachment.cgi?id=116103&action=review

> Source/WebKit/gtk/webkit/webkitwebinspector.cpp:93
> +    PROP_TIMELINE_PROFILING_ENABLED

The constant should be removed as well, please discuss it with the Gtk folks.
Comment 6 Pavel Feldman 2011-11-22 01:52:28 PST
Committed r100985: <http://trac.webkit.org/changeset/100985>