Bug 72879 – [GTK] Add a way to skip unit tests in the bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

testdownload is currently failing in the bots, but not for us, it would be great to be able to skip tests in the bots. It would be even better to be able to skip paths of the tests, but gtester doesn't implement it, so we need to skip full tests for now.

[Carlos Garcia Campos]

Created attachment 116078 [details]
Patch

I've rewritten the whole script in python to make it easier to modify for everybody. Last time we had to change this script we already agreed with kov to port it to python, but we didn't do it in the end.

[Philippe Normand]

Comment on attachment 116078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116078&action=review

Looks good, thanks! Just a little nit to fix before landing.

> Tools/Scripts/run-gtk-tests:79
> +        raise

I don't think this works, raise needs a following exception, you should use the traceback module:

import traceback
traceback.print_exc()

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 116078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116078&action=review
> 
> Looks good, thanks! Just a little nit to fix before landing.
> 
> > Tools/Scripts/run-gtk-tests:79
> > +        raise
> 
> I don't think this works, raise needs a following exception, you should use the traceback module:
> 
> import traceback
> traceback.print_exc()

that raise was just for debugging, I forgot to remove it before sending the patch.

[Carlos Garcia Campos]

Committed r100919: <http://trac.webkit.org/changeset/100919>

[Philippe Normand]

Borked our Debug bots!

Traceback (most recent call last):
  File "./Tools/Scripts/run-gtk-tests", line 84, in <module>
    sys.exit(TestRunner().run())
  File "./Tools/Scripts/run-gtk-tests", line 38, in __init__
    for test_file in os.listdir(os.path.join(self._programs_path, test_dir)):
OSError: [Errno 2] No such file or directory: '/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Release/Programs/unittests

That's because we never call set-webkit-configuration it seems. So webkit-build-directory always returns Release.

[Philippe Normand]

(In reply to comment #5)
> Borked our Debug bots!
> 
> Traceback (most recent call last):
>   File "./Tools/Scripts/run-gtk-tests", line 84, in <module>
>     sys.exit(TestRunner().run())
>   File "./Tools/Scripts/run-gtk-tests", line 38, in __init__
>     for test_file in os.listdir(os.path.join(self._programs_path, test_dir)):
> OSError: [Errno 2] No such file or directory: '/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Release/Programs/unittests
> 
> That's because we never call set-webkit-configuration it seems. So webkit-build-directory always returns Release.

Landed a temporary workaround http://trac.webkit.org/changeset/100938

[Philippe Normand]

See also bug 72902