Bug 72873 – Web Inspector: [Regression] Successfully loaded XHRs are shown as canceled.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Caused by https://bugs.webkit.org/show_bug.cgi?id=71149

[Vsevolod Vlasov]

Created attachment 116513 [details]
Patch

[Nate Chapin]

Comment on attachment 116513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116513&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:114
> +void SubresourceLoader::cancelCachedResourceLoad()
> +{
> +    if (m_state != Initialized)
> +        return;
> +
> +    ResourceLoader::cancel();
> +}

Does it break other things to name this cancel() and override ResourceLoader::cancel() ?

[Vsevolod Vlasov]

(In reply to comment #2)
> (From update of attachment 116513 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116513&action=review
> 
> > Source/WebCore/loader/SubresourceLoader.cpp:114
> > +void SubresourceLoader::cancelCachedResourceLoad()
> > +{
> > +    if (m_state != Initialized)
> > +        return;
> > +
> > +    ResourceLoader::cancel();
> > +}
> 
> Does it break other things to name this cancel() and override ResourceLoader::cancel() ?

Looks like this can break other cancel scenarios, e.g. like here http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/loader/SubresourceLoader.cpp&l=204&type=cs

[Nate Chapin]

Comment on attachment 116513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116513&action=review

>>> Source/WebCore/loader/SubresourceLoader.cpp:114
>>> +}
>> 
>> Does it break other things to name this cancel() and override ResourceLoader::cancel() ?
> 
> Looks like this can break other cancel scenarios, e.g. like here http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/loader/SubresourceLoader.cpp&l=204&type=cs

Alright, thanks for checking.

I'd slightly prefer a name like "cancelIfNotFinishing", but you can feel free to land without another review so long as it still compiles :)

[Vsevolod Vlasov]

Committed r101545: <http://trac.webkit.org/changeset/101545>