Bug 72870 - [GTK] Enable WebSocket hybi tests
Summary: [GTK] Enable WebSocket hybi tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Yuta Kitamura
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-11-21 04:14 PST by Yuta Kitamura
Modified: 2011-11-21 19:39 PST (History)
1 user (show)

See Also:


Attachments
Patch (6.74 KB, patch)
2011-11-21 04:32 PST, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-11-21 04:14:26 PST
Implement LayoutTestController.overridePreference("WebKitHixie76WebSocketProtocolEnabled", bool) and enable WebSocket hybi tests (tests under http/tests/websocket/tests/hybi/).
Comment 1 Yuta Kitamura 2011-11-21 04:32:26 PST
Created attachment 116067 [details]
Patch
Comment 2 Xan Lopez 2011-11-21 10:46:36 PST
Comment on attachment 116067 [details]
Patch

Looks good to me. Thanks!
Comment 3 Yuta Kitamura 2011-11-21 19:20:14 PST
Thanks!
Comment 4 WebKit Review Bot 2011-11-21 19:39:15 PST
Comment on attachment 116067 [details]
Patch

Clearing flags on attachment: 116067

Committed r100978: <http://trac.webkit.org/changeset/100978>
Comment 5 WebKit Review Bot 2011-11-21 19:39:19 PST
All reviewed patches have been landed.  Closing bug.