Bug 72869 - [Qt] Clean up MiniBrowser project file after recent changes
Summary: [Qt] Clean up MiniBrowser project file after recent changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-11-21 04:05 PST by Andras Becsi
Modified: 2011-11-21 07:00 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (1.13 KB, patch)
2011-11-21 04:07 PST, Andras Becsi
vestbo: review-
Details | Formatted Diff | Diff
proposed patch (1.05 KB, patch)
2011-11-21 04:35 PST, Andras Becsi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-11-21 04:05:52 PST
We use OTHER_FILES for the QML files to be listed in Qt Creator. Remove nonexistent files from OTHER_FILES and add the remainig only QML file as a dependency of the project.
Comment 1 Andras Becsi 2011-11-21 04:07:37 PST
Created attachment 116063 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-11-21 04:10:14 PST
Attachment 116063 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/M..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tor Arne Vestbø 2011-11-21 04:25:57 PST
Comment on attachment 116063 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116063&action=review

> Tools/MiniBrowser/qt/MiniBrowser.pro:40
> +PRE_TARGETDEPS += $$OTHER_FILES

This should be handled by CONFIG += resources. If that's broken we should look at what's going on.
Comment 4 Andras Becsi 2011-11-21 04:35:45 PST
Created attachment 116069 [details]
proposed patch

rcc should take care of the dependency, so the dependency bug should not be the scope of this change.
Comment 5 Andras Becsi 2011-11-21 07:00:06 PST
Comment on attachment 116069 [details]
proposed patch

Clearing flags on attachment: 116069

Committed r100910: <http://trac.webkit.org/changeset/100910>
Comment 6 Andras Becsi 2011-11-21 07:00:13 PST
All reviewed patches have been landed.  Closing bug.