Bug 72867 – REGRESSION(r100856): New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/100856 broke the build:
New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 116058 [details]
ROLLOUT of r100856

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Review Bot]

Comment on attachment 116058 [details]
ROLLOUT of r100856

Clearing flags on attachment: 116058

Committed r100896: <http://trac.webkit.org/changeset/100896>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Did it need a rebaseline?  What was the issue?  Please comment in the original bug when you roll out changes to explain why you're rolling them out. :(

[Mike Lawther]

I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing.

I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory.

[Dimitri Glazkov (Google)]

(In reply to comment #5)
> I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing.
> 
> I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory.

It looks like the were no pixel results submitted with the test. Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results.

[Antti Koivisto]

(In reply to comment #6)
> Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results.

I don't think so. The bug tested is very sensitive to the exact document structure. Inclusion of <script> in the head likely to make the bug disappear.

[Antti Koivisto]

It would actually be good to mention that in the test case.