Bug 72865 - [Qt] WebSocket close tests are failing
Summary: [Qt] WebSocket close tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Yuta Kitamura
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-11-21 00:44 PST by Yuta Kitamura
Modified: 2011-11-21 01:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2011-11-21 00:59 PST, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-11-21 00:44:53 PST
The following five tests are failing:

- http/tests/websocket/tests/hybi/close-before-open.html
- http/tests/websocket/tests/hybi/close-code-and-reason.html
- http/tests/websocket/tests/hybi/close.html
- http/tests/websocket/tests/hybi/workers/close.html
- http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

These tests are failing because SocketStreamHandleQt::platformClose() does not emit didCloseSocketStream() callback when it is called before the connection is established.

I'm going to post a patch shortly.
Comment 1 Yuta Kitamura 2011-11-21 00:59:46 PST
Created attachment 116048 [details]
Patch
Comment 2 Simon Hausmann 2011-11-21 01:24:25 PST
Comment on attachment 116048 [details]
Patch

Thanks!
Comment 3 WebKit Review Bot 2011-11-21 01:43:14 PST
Comment on attachment 116048 [details]
Patch

Clearing flags on attachment: 116048

Committed r100891: <http://trac.webkit.org/changeset/100891>
Comment 4 WebKit Review Bot 2011-11-21 01:43:18 PST
All reviewed patches have been landed.  Closing bug.