Bug 72858 - WTF::String has extra WTF_EXPORT_PRIVATE
Summary: WTF::String has extra WTF_EXPORT_PRIVATE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 67852
  Show dependency treegraph
 
Reported: 2011-11-20 22:15 PST by Hajime Morrita
Modified: 2011-11-23 01:11 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2011-11-21 03:33 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-11-20 22:15:10 PST
Some inline method on WTF::String has declared as WTF_EXPORT_PRIVATE, 
which is incompatible against Mac port. Mac port forbid inline exported functions.
Comment 1 Hajime Morrita 2011-11-21 03:33:53 PST
Created attachment 116060 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-21 03:35:19 PST
Attachment 116060 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/text/WTFString.h:114:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hajime Morrita 2011-11-21 03:41:18 PST
The style error was a false charge. It was already there.
Comment 4 Hajime Morrita 2011-11-22 00:11:21 PST
Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE.
Comment 5 Kevin Ollivier 2011-11-22 09:37:46 PST
(In reply to comment #4)
> Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE.

Sure, will do, but it might be a day or two because I want to double-check that wx still links okay after removing them. I vaguely remember having some sort of error when I didn't declare those symbols exported, but it's been a long time so I need to double-check it.
Comment 6 Kevin Ollivier 2011-11-22 20:26:14 PST
Comment on attachment 116060 [details]
Patch

Okay, I double-checked wx compilation and it looks fine, so these can go.
Comment 7 WebKit Review Bot 2011-11-23 01:11:11 PST
Comment on attachment 116060 [details]
Patch

Clearing flags on attachment: 116060

Committed r101054: <http://trac.webkit.org/changeset/101054>
Comment 8 WebKit Review Bot 2011-11-23 01:11:17 PST
All reviewed patches have been landed.  Closing bug.