Some inline method on WTF::String has declared as WTF_EXPORT_PRIVATE, which is incompatible against Mac port. Mac port forbid inline exported functions.
Created attachment 116060 [details] Patch
Attachment 116060 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/text/WTFString.h:114: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
The style error was a false charge. It was already there.
Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE.
(In reply to comment #4) > Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE. Sure, will do, but it might be a day or two because I want to double-check that wx still links okay after removing them. I vaguely remember having some sort of error when I didn't declare those symbols exported, but it's been a long time so I need to double-check it.
Comment on attachment 116060 [details] Patch Okay, I double-checked wx compilation and it looks fine, so these can go.
Comment on attachment 116060 [details] Patch Clearing flags on attachment: 116060 Committed r101054: <http://trac.webkit.org/changeset/101054>
All reviewed patches have been landed. Closing bug.