Bug 72847 – Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Shinya Kawanaka]

Current SpellChecker::requestCheckingFor takes Node as an argument.
This may be too wide, so should be Range.
Also, this is required to implement asynchronous spellchecker.

[Shinya Kawanaka]

Created attachment 116023 [details]
Patch

[Hajime Morrita]

Comment on attachment 116023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116023&action=review

> Source/WebCore/editing/Editor.cpp:415
>      Node* nodeToCheck = m_frame->selection()->rootEditableElement();

We can create a Range from the selection, instead of using the root editable node. It would save the size of the checked text.
I don't think the change needs to be done in this patch. But registering a new bug is highly welcome ;-)

> Source/WebCore/editing/Editor.cpp:416
> +    RefPtr<Range> rangeToCheck = Range::create(m_frame->document(), firstPositionInNode(nodeToCheck), lastPositionInNode(nodeToCheck));

You can use PassRefPtr here.

> Source/WebCore/editing/SpellChecker.cpp:-111
> -void SpellChecker::requestCheckingFor(TextCheckingTypeMask mask, Node* node)

A pattern is to give a usual name to outer function and call internal one as XxInternal() or doXx()

[Shinya Kawanaka]

Created attachment 116028 [details]
Patch

[Hajime Morrita]

Comment on attachment 116028 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 116028 [details]
Patch

Attachment 116028 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10533167

New failing tests:
editing/pasteboard/paste-table-001.html

[Shinya Kawanaka]

Created attachment 116034 [details]
Patch

[WebKit Review Bot]

Comment on attachment 116034 [details]
Patch

Clearing flags on attachment: 116034

Committed r100890: <http://trac.webkit.org/changeset/100890>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.