Bug 72846 - Implement CSS border image properties in CSSStyleApplyProperty.
: Implement CSS border image properties in CSSStyleApplyProperty.
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-20 20:17 PST by
Modified: 2011-11-28 02:05 PST (History)


Attachments
Patch (7.46 KB, patch)
2011-11-20 21:02 PST, Luke Macpherson
no flags Review Patch | Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2011-11-27 15:33 PST, Luke Macpherson
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-20 20:17:16 PST
Implement CSS border image properties in CSSStyleApplyProperty.
------- Comment #1 From 2011-11-20 21:02:32 PST -------
Created an attachment (id=116024) [details]
Patch
------- Comment #2 From 2011-11-27 05:34:02 PST -------
(From update of attachment 116024 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
> +          void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>

This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
> +        if (borderImageType)
> +            image.setMaskDefaults();

This check should be "if (borderImageType == Mask)" for readability.
------- Comment #3 From 2011-11-27 15:06:56 PST -------
(From update of attachment 116024 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
>> +          void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>
> 
> This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.

The reason is that mapNinePieceImage is private, and I both don't want to make it public, and don't want to make all the ApplyProperty* classes friends (because they too have no externally visible interfaces). Passing in the pointer seemed like the best solution here.

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
>> +            image.setMaskDefaults();
> 
> This check should be "if (borderImageType == Mask)" for readability.

Will do.
------- Comment #4 From 2011-11-27 15:33:47 PST -------
Created an attachment (id=116683) [details]
Patch
------- Comment #5 From 2011-11-27 16:44:20 PST -------
(From update of attachment 116683 [details])
Duh, I didn't notice that mapNinePieceImage() is private.
r=me
------- Comment #6 From 2011-11-28 02:05:45 PST -------
(From update of attachment 116683 [details])
Clearing flags on attachment: 116683

Committed r101238: <http://trac.webkit.org/changeset/101238>
------- Comment #7 From 2011-11-28 02:05:51 PST -------
All reviewed patches have been landed.  Closing bug.