Implement CSS border image properties in CSSStyleApplyProperty.

Implement CSS border image properties in CSSStyleApplyProperty.

Created an attachment (id=116024) [details]
Patch

(From update of attachment 116024 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
> +          void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>

This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
> +        if (borderImageType)
> +            image.setMaskDefaults();

This check should be "if (borderImageType == Mask)" for readability.

(From update of attachment 116024 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
>> +          void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>
> 
> This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.

The reason is that mapNinePieceImage is private, and I both don't want to make it public, and don't want to make all the ApplyProperty* classes friends (because they too have no externally visible interfaces). Passing in the pointer seemed like the best solution here.

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
>> +            image.setMaskDefaults();
> 
> This check should be "if (borderImageType == Mask)" for readability.

Will do.

Created an attachment (id=116683) [details]
Patch

(From update of attachment 116683 [details])
Duh, I didn't notice that mapNinePieceImage() is private.
r=me

(From update of attachment 116683 [details])
Clearing flags on attachment: 116683

Committed r101238: <http://trac.webkit.org/changeset/101238>

All reviewed patches have been landed.  Closing bug.