WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72846
Implement CSS border image properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72846
Summary
Implement CSS border image properties in CSSStyleApplyProperty.
Luke Macpherson
Reported
2011-11-20 20:17:16 PST
Implement CSS border image properties in CSSStyleApplyProperty.
Attachments
Patch
(7.46 KB, patch)
2011-11-20 21:02 PST
,
Luke Macpherson
no flags
Details
Formatted Diff
Diff
Patch
(7.45 KB, patch)
2011-11-27 15:33 PST
,
Luke Macpherson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Luke Macpherson
Comment 1
2011-11-20 21:02:32 PST
Created
attachment 116024
[details]
Patch
Andreas Kling
Comment 2
2011-11-27 05:34:02 PST
Comment on
attachment 116024
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116024&action=review
> Source/WebCore/css/CSSStyleApplyProperty.cpp:580 > + void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>
This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.
> Source/WebCore/css/CSSStyleApplyProperty.cpp:587 > + if (borderImageType) > + image.setMaskDefaults();
This check should be "if (borderImageType == Mask)" for readability.
Luke Macpherson
Comment 3
2011-11-27 15:06:56 PST
Comment on
attachment 116024
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116024&action=review
>> Source/WebCore/css/CSSStyleApplyProperty.cpp:580 >> + void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)> > > This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.
The reason is that mapNinePieceImage is private, and I both don't want to make it public, and don't want to make all the ApplyProperty* classes friends (because they too have no externally visible interfaces). Passing in the pointer seemed like the best solution here.
>> Source/WebCore/css/CSSStyleApplyProperty.cpp:587 >> + image.setMaskDefaults(); > > This check should be "if (borderImageType == Mask)" for readability.
Will do.
Luke Macpherson
Comment 4
2011-11-27 15:33:47 PST
Created
attachment 116683
[details]
Patch
Andreas Kling
Comment 5
2011-11-27 16:44:20 PST
Comment on
attachment 116683
[details]
Patch Duh, I didn't notice that mapNinePieceImage() is private. r=me
WebKit Review Bot
Comment 6
2011-11-28 02:05:45 PST
Comment on
attachment 116683
[details]
Patch Clearing flags on attachment: 116683 Committed
r101238
: <
http://trac.webkit.org/changeset/101238
>
WebKit Review Bot
Comment 7
2011-11-28 02:05:51 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug