Bug 72827 - [Qt] [WK2] WebKitTestRunner doesn't build in debug
Summary: [Qt] [WK2] WebKitTestRunner doesn't build in debug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-11-20 11:34 PST by Viatcheslav Ostapenko
Modified: 2011-11-21 08:49 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2011-11-20 11:59 PST, Viatcheslav Ostapenko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-11-20 11:34:50 PST
obj/debug/EventSenderProxyQt.o: In function `WTR::EventSenderProxy::updateTouchPoint(int, int, int)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:325: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestControllerQt.o: In function `WTR::TestControllerRunLoop::start(int)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestInvocationQt.o: In function `WTR::TestInvocation::dumpPixelsAndCompareWithExpected(OpaqueWKImage const*, OpaqueWKArray const*)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:76: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o: In function `WTR::TestController::shared()':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:60: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o: In function `WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:546: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o:/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:694: more undefined references to `WTFReportAssertionFailure' follow
collect2: ld returned 1 exit status
Comment 1 Viatcheslav Ostapenko 2011-11-20 11:59:08 PST
Created attachment 115990 [details]
Patch
Comment 2 Andreas Kling 2011-11-20 13:15:08 PST
Comment on attachment 115990 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2011-11-20 14:21:52 PST
Comment on attachment 115990 [details]
Patch

Rejecting attachment 115990 [details] from commit-queue.

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
Full output: http://queues.webkit.org/results/10534064
Comment 4 Viatcheslav Ostapenko 2011-11-20 15:02:04 PST
(In reply to comment #3)
> (From update of attachment 115990 [details])
> Rejecting attachment 115990 [details] from commit-queue.
> 
> New failing tests:
> platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
> Full output: http://queues.webkit.org/results/10534064

Wow!
How change in Qt exports could fail chromium layout tests? ;)
Comment 5 Viatcheslav Ostapenko 2011-11-21 07:11:12 PST
Comment on attachment 115990 [details]
Patch

I'd like to retry commit queue because this change couldn't break chromium layout tests.
Comment 6 Csaba Osztrogonác 2011-11-21 08:49:00 PST
Comment on attachment 115990 [details]
Patch

Clearing flags on attachment: 115990

Committed r100920: <http://trac.webkit.org/changeset/100920>
Comment 7 Csaba Osztrogonác 2011-11-21 08:49:08 PST
All reviewed patches have been landed.  Closing bug.