Bug 72827 – [Qt] [WK2] WebKitTestRunner doesn't build in debug

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Viatcheslav Ostapenko]

obj/debug/EventSenderProxyQt.o: In function `WTR::EventSenderProxy::updateTouchPoint(int, int, int)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:325: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestControllerQt.o: In function `WTR::TestControllerRunLoop::start(int)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestInvocationQt.o: In function `WTR::TestInvocation::dumpPixelsAndCompareWithExpected(OpaqueWKImage const*, OpaqueWKArray const*)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:76: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o: In function `WTR::TestController::shared()':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:60: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o: In function `WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*)':
/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:546: undefined reference to `WTFReportAssertionFailure'
obj/debug/TestController.o:/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:694: more undefined references to `WTFReportAssertionFailure' follow
collect2: ld returned 1 exit status

[Viatcheslav Ostapenko]

Created attachment 115990 [details]
Patch

[Andreas Kling]

Comment on attachment 115990 [details]
Patch

rs=me

[WebKit Review Bot]

Comment on attachment 115990 [details]
Patch

Rejecting attachment 115990 [details] from commit-queue.

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
Full output: http://queues.webkit.org/results/10534064

[Viatcheslav Ostapenko]

(In reply to comment #3)
> (From update of attachment 115990 [details])
> Rejecting attachment 115990 [details] from commit-queue.
> 
> New failing tests:
> platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
> Full output: http://queues.webkit.org/results/10534064

Wow!
How change in Qt exports could fail chromium layout tests? ;)

[Viatcheslav Ostapenko]

Comment on attachment 115990 [details]
Patch

I'd like to retry commit queue because this change couldn't break chromium layout tests.

[Csaba Osztrogonác]

Comment on attachment 115990 [details]
Patch

Clearing flags on attachment: 115990

Committed r100920: <http://trac.webkit.org/changeset/100920>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.