RESOLVED FIXED 72825
[Qt] Add WebView.view attached property support for dialogs in QML 
https://bugs.webkit.org/show_bug.cgi?id=72825
Summary [Qt] Add WebView.view attached property support for dialogs in QML
Caio Marcelo de Oliveira Filho
Reported 2011-11-20 05:09:33 PST
[Qt] Add WebView.view attached property support for dialogs in QML
Attachments
Patch (9.68 KB, patch)
2011-11-20 05:14 PST, Caio Marcelo de Oliveira Filho 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-11-20 05:14:43 PST
Created attachment 115981 [details] Patch
Simon Hausmann
Comment 2 2011-11-21 00:05:25 PST
Comment on attachment 115981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115981&action=review r=me > Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:143 > + Q_PROPERTY(QQuickWebView* view READ view NOTIFY viewChanged) I guess the property should also be marked FINAL?
Caio Marcelo de Oliveira Filho
Comment 3 2011-11-21 05:29:37 PST
Committed r100905: <http://trac.webkit.org/changeset/100905>
Caio Marcelo de Oliveira Filho
Comment 4 2011-11-21 05:31:55 PST
Comment on attachment 115981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115981&action=review >> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:143 >> + Q_PROPERTY(QQuickWebView* view READ view NOTIFY viewChanged) > > I guess the property should also be marked FINAL? Fixed in the version landed. Thanks!
Note You need to log in before you can comment on or make changes to this bug.