Bug 72825 - [Qt] Add WebView.view attached property support for dialogs in QML
Summary: [Qt] Add WebView.view attached property support for dialogs in QML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-11-20 05:09 PST by Caio Marcelo de Oliveira Filho
Modified: 2011-11-21 05:31 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.68 KB, patch)
2011-11-20 05:14 PST, Caio Marcelo de Oliveira Filho
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-11-20 05:09:33 PST
[Qt] Add WebView.view attached property support for dialogs in QML
Comment 1 Caio Marcelo de Oliveira Filho 2011-11-20 05:14:43 PST
Created attachment 115981 [details]
Patch
Comment 2 Simon Hausmann 2011-11-21 00:05:25 PST
Comment on attachment 115981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115981&action=review

r=me

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:143
> +    Q_PROPERTY(QQuickWebView* view READ view NOTIFY viewChanged)

I guess the property should also be marked FINAL?
Comment 3 Caio Marcelo de Oliveira Filho 2011-11-21 05:29:37 PST
Committed r100905: <http://trac.webkit.org/changeset/100905>
Comment 4 Caio Marcelo de Oliveira Filho 2011-11-21 05:31:55 PST
Comment on attachment 115981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115981&action=review

>> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:143
>> +    Q_PROPERTY(QQuickWebView* view READ view NOTIFY viewChanged)
> 
> I guess the property should also be marked FINAL?

Fixed in the version landed. Thanks!