Bug 72813 - Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
: Remove the dependence on jsonp from more of new-run-webkit-tests and the test...
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-19 16:47 PST by
Modified: 2011-11-19 17:18 PST (History)


Attachments
Patch (6.25 KB, patch)
2011-11-19 16:50 PST, Ojan Vafai
abarth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-19 16:47:30 PST
Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
------- Comment #1 From 2011-11-19 16:50:47 PST -------
Created an attachment (id=115963) [details]
Patch
------- Comment #2 From 2011-11-19 16:57:28 PST -------
(From update of attachment 115963 [details])
Do we need to change anything in garden-o-matic?  It has some code to strip off the JSONP wrapper.  We might need to change it to detect whether the wrapper is there in the first place (or maybe it already does that).
------- Comment #3 From 2011-11-19 17:00:15 PST -------
(From update of attachment 115963 [details])
I'll just commit this now.
------- Comment #4 From 2011-11-19 17:00:48 PST -------
I think garden-o-matic is OK, but I'll double-check before commiting.
------- Comment #5 From 2011-11-19 17:03:54 PST -------
As best I can tell, garden-o-matic only reads full_results.json, which is the only one that's not changing (i.e. it's keeping the jsonp wrapper).
------- Comment #6 From 2011-11-19 17:09:25 PST -------
Ok.  Should we remove the wrapper from that one too?
------- Comment #7 From 2011-11-19 17:13:34 PST -------
Committed r100862: <http://trac.webkit.org/changeset/100862>
------- Comment #8 From 2011-11-19 17:18:12 PST -------
(In reply to comment #6)
> Ok.  Should we remove the wrapper from that one too?

There's a comment in the code about why we can't. After run-webkit-tests, we load results.html as a file URL in the browser. results.html pulls in full_results.json as a file URL. This doesn't work in chromium. So, I'm not really sure how we could fix this without running a local server, which I don't think people would be happy about for run-webkit-tests.