Bug 72812 - [CMake] Make the feature defines for DOM names explicit
Summary: [CMake] Make the feature defines for DOM names explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 72815
  Show dependency treegraph
 
Reported: 2011-11-19 15:34 PST by Patrick R. Gansterer
Modified: 2011-12-01 10:31 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.41 KB, patch)
2011-11-19 15:39 PST, Patrick R. Gansterer
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (11.41 KB, patch)
2011-11-23 08:19 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (11.35 KB, patch)
2011-11-24 02:14 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-11-19 15:34:28 PST
[CMake] Make the feature defines for DOM names explicit
Comment 1 Patrick R. Gansterer 2011-11-19 15:39:21 PST
Created attachment 115962 [details]
Patch
Comment 2 Gyuyoung Kim 2011-11-19 15:55:13 PST
Comment on attachment 115962 [details]
Patch

Attachment 115962 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10417151
Comment 3 Patrick R. Gansterer 2011-11-23 08:19:02 PST
Created attachment 116359 [details]
Patch
Comment 4 Gyuyoung Kim 2011-11-23 17:55:44 PST
Comment on attachment 116359 [details]
Patch

Attachment 116359 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10618191
Comment 5 Gyuyoung Kim 2011-11-23 18:34:04 PST
Comment on attachment 116359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116359&action=review

> Source/cmake/WebKitFeatures.cmake:-46
> -	IF (${_feature})

There are EFL build breaks by this removal.
Comment 6 Patrick R. Gansterer 2011-11-24 02:14:42 PST
Created attachment 116489 [details]
Patch
Comment 7 WebKit Review Bot 2011-12-01 10:31:00 PST
Comment on attachment 116489 [details]
Patch

Clearing flags on attachment: 116489

Committed r101685: <http://trac.webkit.org/changeset/101685>
Comment 8 WebKit Review Bot 2011-12-01 10:31:05 PST
All reviewed patches have been landed.  Closing bug.