Bug 72805 – [GTK] gtk_widget_size_allocate for plugin widgets should happen in the WebView size-allocate method

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Currently gtk_widget_size_allocate is called while rendering the WebView. Ideally this would happen in the size-allocate method of the WebView. This will help illiminate artifacts around plugins will scrolling.

[Martin Robinson]

Created attachment 115974 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 115974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115974&action=review

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:595
> +    g_object_set_data(G_OBJECT(widget), "delayed-allocation", &m_delayedAllocation);

We might use a HashMap instead of a HashSet and store the allocation as the value instead of using g_object_set_data(), see the new windowed plugins patch

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:571
> +        if (static_cast<GtkAllocation*>(g_object_get_data(G_OBJECT(*current), "delayed-allocation"))) {

using a hash map here you simply would do: if (!current->second.isEmpty())

[Martin Robinson]

(In reply to comment #2)

> We might use a HashMap instead of a HashSet and store the allocation as the value instead of using g_object_set_data(), see the new windowed plugins patch

I think we have to use g_object_set_data here because the WebKit layer cannot expose any interface to WebCore.

[Gustavo Noronha (kov)]

Comment on attachment 115974 [details]
Patch

Good idea =)

[WebKit Review Bot]

Comment on attachment 115974 [details]
Patch

Clearing flags on attachment: 115974

Committed r102604: <http://trac.webkit.org/changeset/102604>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Martin Robinson]

*** Bug 26040 has been marked as a duplicate of this bug. ***