Bug 72786 – REGRESSION(r100826): Broke Chromium Mac build (Requested by aklein on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/100826 broke the build:
Broke Chromium Mac build (Requested by aklein on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 115926 [details]
ROLLOUT of r100826

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Adam Klein]

Comment on attachment 115926 [details]
ROLLOUT of r100826

Clearing flags on attachment: 115926

Committed r100842: <http://trac.webkit.org/changeset/100842>

[Adam Klein]

All reviewed patches have been landed.  Closing bug.

[Beth Dakin]

Hey Adam. Thanks for dealing with this. I'm sorry I wasn't around to fix it. 

In the future, if you could comment in the bug that tracked the change that caused the build-bustage that would be helpful (https://bugs.webkit.org/show_bug.cgi?id=72551 in this case). I was not checking email regularly while I was on vacation, but I was actually reloading that bug to see if the change caused any problems, and I would have been able to deal with it sooner if it had been logged in the bug. Linking to the build failure would also be helpful.

[Adam Klein]

(In reply to comment #4)
> Hey Adam. Thanks for dealing with this. I'm sorry I wasn't around to fix it. 
> 
> In the future, if you could comment in the bug that tracked the change that caused the build-bustage that would be helpful (https://bugs.webkit.org/show_bug.cgi?id=72551 in this case). I was not checking email regularly while I was on vacation, but I was actually reloading that bug to see if the change caused any problems, and I would have been able to deal with it sooner if it had been logged in the bug. Linking to the build failure would also be helpful.

Sorry for the lack of detail (and cross-linking), will aim to do better with that in future.

[Beth Dakin]

(In reply to comment #5)
> (In reply to comment #4)
> > Hey Adam. Thanks for dealing with this. I'm sorry I wasn't around to fix it. 
> > 
> > In the future, if you could comment in the bug that tracked the change that caused the build-bustage that would be helpful (https://bugs.webkit.org/show_bug.cgi?id=72551 in this case). I was not checking email regularly while I was on vacation, but I was actually reloading that bug to see if the change caused any problems, and I would have been able to deal with it sooner if it had been logged in the bug. Linking to the build failure would also be helpful.
> 
> Sorry for the lack of detail (and cross-linking), will aim to do better with that in future.

Not a problem. Sounds good. Thanks again!