Bug 72769 - [chromium] fix build rule to copy test plugin for chromium/mac make build
Summary: [chromium] fix build rule to copy test plugin for chromium/mac make build
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-18 16:16 PST by jochen
Modified: 2011-12-19 11:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2011-11-18 16:17 PST, jochen 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2011-11-18 16:16:17 PST 
[chromium] fix build rule to copy test plugin for chromium/mac make build
Comment 1 jochen 2011-11-18 16:17:00 PST 
Created attachment 115903 [details]
Patch
Comment 2 jochen 2011-11-18 16:19:40 PST 
In http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/generator/make.py#1673 the "filename" of the files parameter is extract by taking the last component.

If the files parameter ends in /, this is an empty string, and so copying an directory to a non-existing directory will fail:

If we want to copy dir/ *into* new_dir/, the command cp -aF dir/ new_dir/dir should be executed, and not cp -aF dir/ new_dir/
Comment 3 Nico Weber 2011-11-20 20:05:25 PST 
gyp needs to be fixed to be consistent across generators here. Since it's easy to do, make should probably just be taught to support a trailing /. I filed http://crbug.com/104934 for this.

I don't think this patch is necessary.
Comment 4 Eric Seidel (no email) 2011-12-19 11:08:00 PST 
Comment on attachment 115903 [details]
Patch

OK.  You might also want to file a bug against GYP if they're not warning about this.
Comment 5 Nico Weber 2011-12-19 11:13:12 PST 
Please don't land this as is.