RESOLVED INVALID 72769
[chromium] fix build rule to copy test plugin for chromium/mac make build 
https://bugs.webkit.org/show_bug.cgi?id=72769
Summary [chromium] fix build rule to copy test plugin for chromium/mac make build
jochen
Reported 2011-11-18 16:16:17 PST
[chromium] fix build rule to copy test plugin for chromium/mac make build
Attachments
Patch (1.41 KB, patch)
2011-11-18 16:17 PST, jochen 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2011-11-18 16:17:00 PST
Created attachment 115903 [details] Patch
jochen
Comment 2 2011-11-18 16:19:40 PST
In http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/generator/make.py#1673 the "filename" of the files parameter is extract by taking the last component. If the files parameter ends in /, this is an empty string, and so copying an directory to a non-existing directory will fail: If we want to copy dir/ *into* new_dir/, the command cp -aF dir/ new_dir/dir should be executed, and not cp -aF dir/ new_dir/
Nico Weber
Comment 3 2011-11-20 20:05:25 PST
gyp needs to be fixed to be consistent across generators here. Since it's easy to do, make should probably just be taught to support a trailing /. I filed http://crbug.com/104934 for this. I don't think this patch is necessary.
Eric Seidel (no email)
Comment 4 2011-12-19 11:08:00 PST
Comment on attachment 115903 [details] Patch OK. You might also want to file a bug against GYP if they're not warning about this.
Nico Weber
Comment 5 2011-12-19 11:13:12 PST
Please don't land this as is.
Note You need to log in before you can comment on or make changes to this bug.