WebKit Bugzilla
You need to log in before you can comment on or make changes to this bug.
<rdar://problem/10356943>
Created an attachment (id=115863) [details] Patch
Created an attachment (id=115865) [details] WebKit changes
Attachment 115863 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/notifications/NotificationController.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/notifications/NotificationContents.h:44: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/NotificationContents.h:49: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "ec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "contents" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "ec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationPresenter.h:61: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/notifications/NotificationPresenter.h:77: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/NotificationCenter.h:81: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 12 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created an attachment (id=115866) [details] WebKit2 changes
I tried to break out this really large patch based on project for easier reviewing. While uploading it caught a bunch of style-related bugs which I intend on fixing when I submit. It's just a little difficult to do that with the way the code changes are set up on my local machine.
Attachment 115865 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1 Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 115866 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/C/WKNotificationManager.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:43: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:45: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/WebNotificationManagerProxy.h:53: The parameter name "provider" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/C/WKNotificationManager.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
(From update of attachment 115863 [details]) Attachment 115863 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10519213
(From update of attachment 115863 [details]) Attachment 115863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10495224
(From update of attachment 115865 [details]) Attachment 115865 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10515204
(From update of attachment 115866 [details]) Attachment 115866 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10517296
Created an attachment (id=116315) [details] Attempt to make bots happy
(From update of attachment 116315 [details]) Attachment 116315 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10616115
(From update of attachment 116315 [details]) Attachment 116315 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10602164
(From update of attachment 116315 [details]) Attachment 116315 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10602275
Created an attachment (id=116797) [details] Attempt to make bots happy #2
Created an attachment (id=116810) [details] Attempt to make bots happy #3
(From update of attachment 116810 [details]) Attachment 116810 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10678398
(From update of attachment 116810 [details]) Attachment 116810 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10664832
Created an attachment (id=116816) [details] Attempt to make bots happy #4
Splitting the task out a little bit for easier committing.
Actually never mind. I got my bug organization all wrong. 73253 is this bug. Since I made the mistake of committing it in the other bug, I will mark this as a dupe of 73253 and remove the blocking relationship. Sorry for the confusion. *** This bug has been marked as a duplicate of bug 73253 ***
(From update of attachment 116816 [details]) Cleared review? from attachment 116816 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).