WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 73253
72743
[WK2] Bring web notification support to WK2
https://bugs.webkit.org/show_bug.cgi?id=72743
Summary
[WK2] Bring web notification support to WK2
Jon Lee
Reported
2011-11-18 11:12:40 PST
<
rdar://problem/10356943
>
Attachments
JSC/WebCore changes
(40.43 KB, patch)
2011-11-18 13:39 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
WebKit changes
(16.98 KB, patch)
2011-11-18 13:41 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
WebKit2 changes
(82.83 KB, patch)
2011-11-18 13:42 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Attempt to make bots happy
(140.35 KB, patch)
2011-11-22 21:08 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Attempt to make bots happy #2
(147.03 KB, patch)
2011-11-28 12:00 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Attempt to make bots happy #3
(151.61 KB, patch)
2011-11-28 13:39 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Attempt to make bots happy #4
(153.76 KB, patch)
2011-11-28 14:03 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
Show Obsolete
(7)
View All
Add attachment
proposed patch, testcase, etc.
Jon Lee
Comment 1
2011-11-18 13:39:23 PST
Created
attachment 115863
[details]
JSC/WebCore changes
Jon Lee
Comment 2
2011-11-18 13:41:12 PST
Created
attachment 115865
[details]
WebKit changes
WebKit Review Bot
Comment 3
2011-11-18 13:41:16 PST
Attachment 115863
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/notifications/NotificationController.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/notifications/NotificationContents.h:44: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/NotificationContents.h:49: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:64: The parameter name "ec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "contents" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/Notification.h:65: The parameter name "ec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationPresenter.h:61: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/notifications/NotificationPresenter.h:77: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/notifications/NotificationCenter.h:81: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 12 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jon Lee
Comment 4
2011-11-18 13:42:04 PST
Created
attachment 115866
[details]
WebKit2 changes
Jon Lee
Comment 5
2011-11-18 13:43:14 PST
I tried to break out this really large patch based on project for easier reviewing. While uploading it caught a bunch of style-related bugs which I intend on fixing when I submit. It's just a little difficult to do that with the way the code changes are set up on my local machine.
WebKit Review Bot
Comment 6
2011-11-18 13:43:56 PST
Attachment 115865
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1 Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7
2011-11-18 13:45:35 PST
Attachment 115866
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/C/WKNotificationManager.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:43: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebNotificationClient.h:45: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/WebNotificationManagerProxy.h:53: The parameter name "provider" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/C/WKNotificationManager.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 8
2011-11-18 14:26:58 PST
Comment on
attachment 115863
[details]
JSC/WebCore changes
Attachment 115863
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/10519213
WebKit Review Bot
Comment 9
2011-11-18 14:27:37 PST
Comment on
attachment 115863
[details]
JSC/WebCore changes
Attachment 115863
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10495224
WebKit Review Bot
Comment 10
2011-11-18 14:30:46 PST
Comment on
attachment 115865
[details]
WebKit changes
Attachment 115865
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10515204
Collabora GTK+ EWS bot
Comment 11
2011-11-18 17:57:24 PST
Comment on
attachment 115866
[details]
WebKit2 changes
Attachment 115866
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/10517296
Jon Lee
Comment 12
2011-11-22 21:08:26 PST
Created
attachment 116315
[details]
Attempt to make bots happy
Early Warning System Bot
Comment 13
2011-11-22 21:19:02 PST
Comment on
attachment 116315
[details]
Attempt to make bots happy
Attachment 116315
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/10616115
Gustavo Noronha (kov)
Comment 14
2011-11-22 21:29:57 PST
Comment on
attachment 116315
[details]
Attempt to make bots happy
Attachment 116315
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/10602164
WebKit Review Bot
Comment 15
2011-11-23 03:30:19 PST
Comment on
attachment 116315
[details]
Attempt to make bots happy
Attachment 116315
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10602275
Jon Lee
Comment 16
2011-11-28 12:00:36 PST
Created
attachment 116797
[details]
Attempt to make bots happy #2
Jon Lee
Comment 17
2011-11-28 13:39:26 PST
Created
attachment 116810
[details]
Attempt to make bots happy #3
Early Warning System Bot
Comment 18
2011-11-28 13:45:23 PST
Comment on
attachment 116810
[details]
Attempt to make bots happy #3
Attachment 116810
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/10678398
WebKit Review Bot
Comment 19
2011-11-28 13:50:59 PST
Comment on
attachment 116810
[details]
Attempt to make bots happy #3
Attachment 116810
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/10664832
Jon Lee
Comment 20
2011-11-28 14:03:00 PST
Created
attachment 116816
[details]
Attempt to make bots happy #4
Jon Lee
Comment 21
2011-11-28 15:15:12 PST
Splitting the task out a little bit for easier committing.
Jon Lee
Comment 22
2011-11-28 17:32:12 PST
Actually never mind. I got my bug organization all wrong. 73253 is this bug. Since I made the mistake of committing it in the other bug, I will mark this as a dupe of 73253 and remove the blocking relationship. Sorry for the confusion. *** This bug has been marked as a duplicate of
bug 73253
***
Eric Seidel (no email)
Comment 23
2011-12-19 11:20:40 PST
Comment on
attachment 116816
[details]
Attempt to make bots happy #4 Cleared review? from
attachment 116816
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug