Bug 72735 - [GTK] Don't load GAIL when using GTK 3.2 or greater
Summary: [GTK] Don't load GAIL when using GTK 3.2 or greater
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anton Obzhirov
Keywords: Gtk
: 119675 (view as bug list)
Depends on:
Reported: 2011-11-18 09:00 PST by Mario Sanchez Prada
Modified: 2013-08-12 10:15 PDT (History)
6 users (show)

See Also:

Patch (4.00 KB, patch)
2013-08-12 03:17 PDT, Anton Obzhirov
no flags Details | Formatted Diff | Diff
Patch (4.01 KB, patch)
2013-08-12 05:35 PDT, Anton Obzhirov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-11-18 09:00:36 PST
As it was suggested by Philippe in bug 72732 (https://bugs.webkit.org/show_bug.cgi?id=72732#c2), opening this bug to remind that GAIL shouldn't be loaded after upgrading to GTK 3.2, since it will stop being a GTK+ module from that version on (it will become part of GTK+ itself).

Among perhaps other implications, one is that using initializeTestingFramework() in testatk.c shouldn't be needed anymore since GTK 3.2, and so it should be replaced by gtk_test_init().
Comment 1 Mario Sanchez Prada 2013-08-12 03:05:25 PDT
*** Bug 119675 has been marked as a duplicate of this bug. ***
Comment 2 Anton Obzhirov 2013-08-12 03:17:44 PDT
Created attachment 208525 [details]
Comment 3 WebKit Commit Bot 2013-08-12 03:19:40 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2013-08-12 03:30:56 PDT
Comment on attachment 208525 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208525&action=review

> Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:34
> +    // Make sure that the ATK bridge are loaded.

Comment 5 Anton Obzhirov 2013-08-12 05:35:37 PDT
Created attachment 208536 [details]

Thanks Carlos for the review. Now uploading a new patch since I'm not a committer yet
Comment 6 Mario Sanchez Prada 2013-08-12 05:36:25 PDT
Comment on attachment 208536 [details]

Just setting the cq+ flag
Comment 7 WebKit Commit Bot 2013-08-12 10:15:12 PDT
Comment on attachment 208536 [details]

Clearing flags on attachment: 208536

Committed r153947: <http://trac.webkit.org/changeset/153947>
Comment 8 WebKit Commit Bot 2013-08-12 10:15:15 PDT
All reviewed patches have been landed.  Closing bug.