Bug 72735 – [GTK] Don't load GAIL when using GTK 3.2 or greater

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

As it was suggested by Philippe in bug 72732 (https://bugs.webkit.org/show_bug.cgi?id=72732#c2), opening this bug to remind that GAIL shouldn't be loaded after upgrading to GTK 3.2, since it will stop being a GTK+ module from that version on (it will become part of GTK+ itself).

Among perhaps other implications, one is that using initializeTestingFramework() in testatk.c shouldn't be needed anymore since GTK 3.2, and so it should be replaced by gtk_test_init().

[Mario Sanchez Prada]

*** Bug 119675 has been marked as a duplicate of this bug. ***

[Anton Obzhirov]

Created attachment 208525 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 208525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208525&action=review

> Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:34
> +    // Make sure that the ATK bridge are loaded.

s/are/is/

[Anton Obzhirov]

Created attachment 208536 [details]
Patch

Thanks Carlos for the review. Now uploading a new patch since I'm not a committer yet

[Mario Sanchez Prada]

Comment on attachment 208536 [details]
Patch

Just setting the cq+ flag

[WebKit Commit Bot]

Comment on attachment 208536 [details]
Patch

Clearing flags on attachment: 208536

Committed r153947: <http://trac.webkit.org/changeset/153947>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.