Bug 72734 - Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
Summary: Web Inspector:[protocol] actual JSON messages do not conform to Inspector.jso...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 72824
  Show dependency tree / graph
 
Reported: 2011-11-18 08:59 PST by Peter Rybin
Modified: 2011-11-20 00:15 PST (History)
13 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2011-11-19 08:37 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2011-11-18 08:59:28 PST 
InspectorApplicationCacheAgent.cpp:188 (r100177)
size is declared 'string', but actual type is 'integer'; why 'size' is declared 'string' in the first place?
Comment 1 Peter Rybin 2011-11-18 09:07:21 PST 
This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
Comment 2 Vsevolod Vlasov 2011-11-19 08:37:49 PST 
Created attachment 115951 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-19 09:32:38 PST 
Comment on attachment 115951 [details]
Patch

Clearing flags on attachment: 115951

Committed r100857: <http://trac.webkit.org/changeset/100857>
Comment 4 WebKit Review Bot 2011-11-19 09:32:43 PST 
All reviewed patches have been landed.  Closing bug.