InspectorStyleSheet.cpp:141 'sourceLine' is declared 'string' but actual value is 'integer' InspectorStyleSheet.cpp:246 'styleId' property must be set unconditionally, it is not optional. InspectorStyleSheet.cpp:248-249 'witdh' and 'height' property are declared 'integer', but actual values are 'string' InspectorStyleSheet.cpp:448 warning: 'text' property is undeclared InspectorStyleSheet.cpp:499 'shorthandName' must be set unconditionally, it is not optional InspectorStyleSheet.cpp:795 'ruleId' must be set unconditionally, it is not optional (all line numbers are as in r100177) This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.
Created attachment 116068 [details] Patch
Comment on attachment 116068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116068&action=review > Source/WebCore/inspector/Inspector.json:1520 > + { "name": "styleId", "$ref": "CSSStyleId", "optional": true, "description": "The CSS style identifier (absent for computed styles and attribute styles)." }, You should use different structure for computed and matched styles.
Created attachment 116094 [details] Patch
Attachment 116094 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.cpp:317: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorCSSAgent.h:67: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 116094 [details] Patch Clearing flags on attachment: 116094 Committed r100987: <http://trac.webkit.org/changeset/100987>
All reviewed patches have been landed. Closing bug.