Bug 72730 - Web Inspector: add integration test for compiler source maps.
Summary: Web Inspector: add integration test for compiler source maps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on: 73032
Blocks: 72824
  Show dependency tree / graph
 
Reported: 2011-11-18 07:34 PST by Pavel Podivilov
Modified: 2011-11-24 01:11 PST (History)
13 users (show)

See Also:

Attachments
Patch (12.61 KB, patch)
2011-11-18 07:37 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch (15.71 KB, patch)
2011-11-18 08:29 PST, Pavel Podivilov 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-11-18 07:34:47 PST 
Web Inspector: add integration test for compiler source maps.
Comment 1 Pavel Podivilov 2011-11-18 07:37:09 PST 
Created attachment 115806 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-18 08:06:32 PST 
Comment on attachment 115806 [details]
Patch

Attachment 115806 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10393163

New failing tests:
http/tests/inspector/compiler-source-mapping-debug.html
Comment 3 Pavel Podivilov 2011-11-18 08:29:51 PST 
Created attachment 115817 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-18 09:01:15 PST 
Comment on attachment 115817 [details]
Patch

Attachment 115817 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10518133

New failing tests:
http/tests/inspector/compiler-source-mapping-debug.html
Comment 5 Pavel Feldman 2011-11-21 01:23:30 PST 
Comment on attachment 115817 [details]
Patch

Make sure it compiles under chromium prior to landing.
Comment 6 Pavel Podivilov 2011-11-23 05:11:19 PST 
Committed r101069: <http://trac.webkit.org/changeset/101069>
Comment 7 Adam Klein 2011-11-23 10:53:22 PST 
(In reply to comment #4)
> (From update of attachment 115817 [details])
> Attachment 115817 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10518133
> 
> New failing tests:
> http/tests/inspector/compiler-source-mapping-debug.html

As predicted by the EWS, this new test is always timing out on the bots:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Fcompiler-source-mapping-debug.html

I intend to roll this out, since the only point of this patch was to add a test.
Comment 8 Pavel Podivilov 2011-11-24 01:10:54 PST 
Committed r101128: <http://trac.webkit.org/changeset/101128>
Comment 9 Pavel Podivilov 2011-11-24 01:11:27 PST 
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 115817 [details] [details])
> > Attachment 115817 [details] [details] did not pass chromium-ews (chromium-xvfb):
> > Output: http://queues.webkit.org/results/10518133
> > 
> > New failing tests:
> > http/tests/inspector/compiler-source-mapping-debug.html
> 
> As predicted by the EWS, this new test is always timing out on the bots:
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Fcompiler-source-mapping-debug.html
> 
> I intend to roll this out, since the only point of this patch was to add a test.

Sorry and thanks for rolling it out!