RESOLVED FIXED 72730
Web Inspector: add integration test for compiler source maps. 
https://bugs.webkit.org/show_bug.cgi?id=72730
Summary Web Inspector: add integration test for compiler source maps.
Pavel Podivilov
Reported 2011-11-18 07:34:47 PST
Web Inspector: add integration test for compiler source maps.
Attachments
Patch (12.61 KB, patch)
2011-11-18 07:37 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (15.71 KB, patch)
2011-11-18 08:29 PST, Pavel Podivilov 		pfeldman: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-11-18 07:37:09 PST
Created attachment 115806 [details] Patch
WebKit Review Bot
Comment 2 2011-11-18 08:06:32 PST
Comment on attachment 115806 [details] Patch Attachment 115806 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10393163 New failing tests: http/tests/inspector/compiler-source-mapping-debug.html
Pavel Podivilov
Comment 3 2011-11-18 08:29:51 PST
Created attachment 115817 [details] Patch
WebKit Review Bot
Comment 4 2011-11-18 09:01:15 PST
Comment on attachment 115817 [details] Patch Attachment 115817 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10518133 New failing tests: http/tests/inspector/compiler-source-mapping-debug.html
Pavel Feldman
Comment 5 2011-11-21 01:23:30 PST
Comment on attachment 115817 [details] Patch Make sure it compiles under chromium prior to landing.
Pavel Podivilov
Comment 6 2011-11-23 05:11:19 PST
Committed r101069: <http://trac.webkit.org/changeset/101069>
Adam Klein
Comment 7 2011-11-23 10:53:22 PST
(In reply to comment #4) > (From update of attachment 115817 [details]) > Attachment 115817 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10518133 > > New failing tests: > http/tests/inspector/compiler-source-mapping-debug.html As predicted by the EWS, this new test is always timing out on the bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Fcompiler-source-mapping-debug.html I intend to roll this out, since the only point of this patch was to add a test.
Pavel Podivilov
Comment 8 2011-11-24 01:10:54 PST
Committed r101128: <http://trac.webkit.org/changeset/101128>
Pavel Podivilov
Comment 9 2011-11-24 01:11:27 PST
(In reply to comment #7) > (In reply to comment #4) > > (From update of attachment 115817 [details] [details]) > > Attachment 115817 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/10518133 > > > > New failing tests: > > http/tests/inspector/compiler-source-mapping-debug.html > > As predicted by the EWS, this new test is always timing out on the bots: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Fcompiler-source-mapping-debug.html > > I intend to roll this out, since the only point of this patch was to add a test. Sorry and thanks for rolling it out!
Note You need to log in before you can comment on or make changes to this bug.