Bug 72717 - [Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer
Summary: [Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-18 05:28 PST by Zeno Albisser
Modified: 2011-11-18 05:49 PST (History)
3 users (show)

See Also:


Attachments
patch for review. (2.28 KB, patch)
2011-11-18 05:31 PST, Zeno Albisser
no flags Details | Formatted Diff | Diff
patch for review. (3.76 KB, patch)
2011-11-18 05:43 PST, Zeno Albisser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-11-18 05:28:33 PST
SSIA
Comment 1 Zeno Albisser 2011-11-18 05:31:56 PST
Created attachment 115787 [details]
patch for review.
Comment 2 WebKit Review Bot 2011-11-18 05:34:34 PST
Attachment 115787 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:184:  The parameter name "engine" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zeno Albisser 2011-11-18 05:34:41 PST
Comment on attachment 115787 [details]
patch for review.

there is still something missing.
Comment 4 Zeno Albisser 2011-11-18 05:43:09 PST
Created attachment 115791 [details]
patch for review.
Comment 5 Zeno Albisser 2011-11-18 05:49:10 PST
Comment on attachment 115791 [details]
patch for review.

Clearing flags on attachment: 115791

Committed r100760: <http://trac.webkit.org/changeset/100760>
Comment 6 Zeno Albisser 2011-11-18 05:49:19 PST
All reviewed patches have been landed.  Closing bug.