Bug 72710 - [CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
Summary: [CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-18 03:26 PST by Patrick R. Gansterer
Modified: 2011-11-18 09:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.26 KB, patch)
2011-11-18 03:27 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-11-18 03:26:16 PST 
[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
Comment 1 Patrick R. Gansterer 2011-11-18 03:27:12 PST 
Created attachment 115778 [details]
Patch
Comment 2 Brent Fulgham 2011-11-18 09:09:19 PST 
Comment on attachment 115778 [details]
Patch

I'm not sure I understand the change.  Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it?  Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it.

But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files.
Comment 3 Patrick R. Gansterer 2011-11-18 09:10:41 PST 
(In reply to comment #2)
> (From update of attachment 115778 [details])
> I'm not sure I understand the change.  Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it?  Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it.
> 
> But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files.

Its moved before the include(Options$PORT}).
In OptionsWinApple.cmake is then a SET(WEBKIT_PORT_DIR win), wich will overwrite the default of WinApple
Comment 4 Brent Fulgham 2011-11-18 09:12:03 PST 
Comment on attachment 115778 [details]
Patch

Looks great.
Comment 5 WebKit Review Bot 2011-11-18 09:49:28 PST 
Comment on attachment 115778 [details]
Patch

Clearing flags on attachment: 115778

Committed r100785: <http://trac.webkit.org/changeset/100785>
Comment 6 WebKit Review Bot 2011-11-18 09:49:32 PST 
All reviewed patches have been landed.  Closing bug.