Bug 72710 – [CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Patrick R. Gansterer]

[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files

[Patrick R. Gansterer]

Created attachment 115778 [details]
Patch

[Brent Fulgham]

Comment on attachment 115778 [details]
Patch

I'm not sure I understand the change.  Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it?  Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it.

But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files.

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 115778 [details])
> I'm not sure I understand the change.  Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it?  Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it.
> 
> But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files.

Its moved before the include(Options$PORT}).
In OptionsWinApple.cmake is then a SET(WEBKIT_PORT_DIR win), wich will overwrite the default of WinApple

[Brent Fulgham]

Comment on attachment 115778 [details]
Patch

Looks great.

[WebKit Review Bot]

Comment on attachment 115778 [details]
Patch

Clearing flags on attachment: 115778

Committed r100785: <http://trac.webkit.org/changeset/100785>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.