In order to parse change logs from different directories and correlate entries, we need a way to determine which change log entry corresponds to which revision.
Created attachment 115770 [details] Patch
Attachment 115770 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:256: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:258: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:260: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:264: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:266: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:272: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:274: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:277: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:279: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:282: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:286: trailing whitespace [pep8/W291] [5] Total errors found: 11 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > If any of these errors are false positives, please file a bug against check-webkit-style. Indeed this is a false positive. The trailing space is required for svn blame format.
Filed https://bugs.webkit.org/show_bug.cgi?id=72706 for the style checker.
Ping reviewers.
Comment on attachment 115770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115770&action=review Looks good. > Tools/Scripts/webkitpy/common/checkout/changelog.py:287 > + most_probable_revision = max(revisions_in_entry, key=revisions_in_entry.__getitem__) if revisions_in_entry else None I'm not sure I understand this? Also, isn't there a getitem helper used for this sort of thing? Object.getitem orsoemthing? Maybe I'm thinking of operator.itemgetter?
Comment on attachment 115770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115770&action=review > Tools/Scripts/webkitpy/common/checkout/changelog.py:247 > + def _sepearate_revision_and_line(line): fyi, typo: sepearate
(In reply to comment #6) > (From update of attachment 115770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115770&action=review > > Looks good. > > > Tools/Scripts/webkitpy/common/checkout/changelog.py:287 > > + most_probable_revision = max(revisions_in_entry, key=revisions_in_entry.__getitem__) if revisions_in_entry else None > > I'm not sure I understand this? Also, isn't there a getitem helper used for this sort of thing? Object.getitem orsoemthing? Maybe I'm thinking of operator.itemgetter? Here, I'm taking the revision that appear most frequently as the guess.
(In reply to comment #7) > (From update of attachment 115770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115770&action=review > > > Tools/Scripts/webkitpy/common/checkout/changelog.py:247 > > + def _sepearate_revision_and_line(line): > > fyi, typo: sepearate Will fix.
Thanks for the review. Landing it now.
Committed r101901: <http://trac.webkit.org/changeset/101901>