Bug 72677 - Remove more direct uses of os.path
Summary: Remove more direct uses of os.path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 16:09 PST by Eric Seidel (no email)
Modified: 2022-02-27 23:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2011-11-17 16:10 PST, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-11-17 16:09:39 PST 
Remove more direct uses of os.path
Comment 1 Eric Seidel (no email) 2011-11-17 16:10:56 PST 
Created attachment 115705 [details]
Patch
Comment 2 Adam Barth 2011-11-17 16:17:14 PST 
Comment on attachment 115705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115705&action=review

> Tools/Scripts/webkitpy/common/config/committervalidator.py:43
> +        (path, extension) = os.path.splitext(committers_path)

We should call filesystem.splitext.  The motivation is to have the tests work the same way on Window and Linux.
Comment 3 Eric Seidel (no email) 2011-11-17 16:23:42 PST 
Committed r100697: <http://trac.webkit.org/changeset/100697>