WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72676
Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
https://bugs.webkit.org/show_bug.cgi?id=72676
Summary
Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
Adam Barth
Reported
2011-11-17 16:06:58 PST
Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
Attachments
Patch
(5.77 KB, patch)
2011-11-17 16:11 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-11-17 16:11:54 PST
Created
attachment 115706
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-11-17 16:14:09 PST
Comment on
attachment 115706
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=115706&action=review
> Source/WebCore/dom/Document.cpp:-4530 > - initDNSPrefetch();
You're sure removing this is OK?
Adam Barth
Comment 3
2011-11-17 16:18:18 PST
(In reply to
comment #2
)
> (From update of
attachment 115706
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=115706&action=review
> > > Source/WebCore/dom/Document.cpp:-4530 > > - initDNSPrefetch(); > > You're sure removing this is OK?
Yes. It's called in the constructor already. Having it in this function is a menace, actually, because it's not safe to call multiple times.
Adam Barth
Comment 4
2011-11-17 16:20:48 PST
Committed
r100696
: <
http://trac.webkit.org/changeset/100696
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug