Bug 72676 - Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
Summary: Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 71745
  Show dependency tree / graph
 
Reported: 2011-11-17 16:06 PST by Adam Barth
Modified: 2011-11-17 16:20 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2011-11-17 16:11 PST, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-11-17 16:06:58 PST 
Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
Comment 1 Adam Barth 2011-11-17 16:11:54 PST 
Created attachment 115706 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-11-17 16:14:09 PST 
Comment on attachment 115706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115706&action=review

> Source/WebCore/dom/Document.cpp:-4530
> -    initDNSPrefetch();

You're sure removing this is OK?
Comment 3 Adam Barth 2011-11-17 16:18:18 PST 
(In reply to comment #2)
> (From update of attachment 115706 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115706&action=review
> 
> > Source/WebCore/dom/Document.cpp:-4530
> > -    initDNSPrefetch();
> 
> You're sure removing this is OK?

Yes.  It's called in the constructor already.  Having it in this function is a menace, actually, because it's not safe to call multiple times.
Comment 4 Adam Barth 2011-11-17 16:20:48 PST 
Committed r100696: <http://trac.webkit.org/changeset/100696>