WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72673
Teach TextFileReader about FileSystem
https://bugs.webkit.org/show_bug.cgi?id=72673
Summary
Teach TextFileReader about FileSystem
Eric Seidel (no email)
Reported
2011-11-17 15:44:53 PST
Teach TextFileReader about FileSystem
Attachments
Patch
(8.40 KB, patch)
2011-11-17 15:45 PST
,
Eric Seidel (no email)
abarth
: review+
abarth
: commit-queue+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-11-17 15:45:58 PST
Created
attachment 115701
[details]
Patch
David Levin
Comment 2
2011-11-17 15:50:08 PST
Comment on
attachment 115701
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=115701&action=review
> Tools/Scripts/webkitpy/style/filereader.py:64 > + # FIXME: Although TextFileReader requires a FileSystem it circumvents it in two places!
It looks like you only flagged one place with a FIXME.
Eric Seidel (no email)
Comment 3
2011-11-17 15:55:28 PST
Committed
r100694
: <
http://trac.webkit.org/changeset/100694
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug