Bug 72673 - Teach TextFileReader about FileSystem
: Teach TextFileReader about FileSystem
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Eric Seidel
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-17 15:44 PST by Eric Seidel
Modified: 2011-11-17 15:55 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.40 KB, patch)
2011-11-17 15:45 PST, Eric Seidel
abarth: review+
abarth: commit‑queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel 2011-11-17 15:44:53 PST
Teach TextFileReader about FileSystem
Comment 1 Eric Seidel 2011-11-17 15:45:58 PST
Created attachment 115701 [details]
Patch
Comment 2 David Levin 2011-11-17 15:50:08 PST
Comment on attachment 115701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115701&action=review

> Tools/Scripts/webkitpy/style/filereader.py:64
> +        # FIXME: Although TextFileReader requires a FileSystem it circumvents it in two places!

It looks like you only flagged one place with a FIXME.
Comment 3 Eric Seidel 2011-11-17 15:55:28 PST
Committed r100694: <http://trac.webkit.org/changeset/100694>